Skip to content

Change default bold parameter to True - #312

Merged
arthurmccray merged 1 commit into
electronmicroscopy:devfrom
maclariz:patch-1
Oct 29, 2026
Merged

arthurmccray merged 1 commit into
electronmicroscopy:devfrom
maclariz:patch-1

Conversation

@maclariz

Copy link
Copy Markdown
Contributor

Making the default bold parameter equal to that given in the docstring

What problem this PR addreseses

What should the reviewer(s) do

Making the default bold parameter equal to that given in the docstring
@maclariz

Copy link
Copy Markdown
Contributor Author

Also, why don't we allow path_effects to be set on a scalebar and its text? This is what I've been doing for my entire career, as often neither white nor black works on an image with a lot of contrast, but black outlined with white or the reverse does so. This is something I support in my Kelvin_STEM scalebars, but if I could just call this it would be even nicer. You'd only need one parameter:
"outline_color": None (default: off)
And then if you supply anything that looks like a color (e.g. named color, hex sequence for a color or a 3- or 4-tuple), then it uses path_effects to draw a Stroke around the text and the bar. I can write the code if you think this is a sesnible plan.

@arthurmccray arthurmccray left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by committee during dev meeting

@arthurmccray

Copy link
Copy Markdown
Collaborator

Also, why don't we allow path_effects to be set on a scalebar and its text?

Agreed this would be helpful @maclariz! I'm sure someone will get to it at some point, but feel free to make the change yourself if you want it quickly :) Always happy to approve and merge quick PRs like that.

@arthurmccray
arthurmccray merged commit ea5d1a3 into electronmicroscopy:dev Oct 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants