Repository navigation
Scalebar: add outline (path effects) and box options to configs and s… - #313
Merged
arthurmccray merged 1 commit intoNov 3, 2026
Merged
Conversation
arthurmccray
approved these changes
Nov 3, 2026
arthurmccray
left a comment
arthurmccray
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @maclariz this looks great! I just updated the tutorial notebook as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this PR addreseses
This now adds colored outlines with patheffects to scalebars.
It also cleans up some other things that boxes and outlines were possible in
add_scalebar_to_axbut these parameters were not declared in the ScalebarConfig Class., so these declarations are now explicit.Changes to
visualization_utils.py,show_params.pyandvisualization.pyDocumentation is updated
What should the reviewer(s) do