Typing readelf and dwarfdump - #657
Merged
Merged
Conversation
Add the easy type annotations to have some test when running with typeguard enabled. Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
Add the easy type annotations to have some test when running with typeguard enabled. Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
eliben
approved these changes
May 26, 2026
Owner
|
Thanks, I'm OK with these minimal additions but agree that doing large changes just for the sake of typing these is overkill. These scripts are mainly used for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last bits from #611 are extra as they do not type the API, but the
scripts/. I have used this to develop the type-hints for the API, but this is not strictly required unless you consider them part of the API.I find them very useful to understand, how the API is supposed to use. As some of their functions are large and complex, having some hint about the types being passed between those functions helps to understand their use.
Typing is not complete and
scripts/is currently not checked: the path is missing inpyproject.toml.main()function. Checking both files would required converting them into modules so they can beimported with different names.assert isinstance(…)orassert … is not Noneto be clean. IMHO that would clutter the code too muchIf one or both is desired, I can have another look.