Signed URL with Cloudfront

[tomasz-tomczyk]

Environment

• Elixir version (elixir -v): 1.14.0-rc.0
• Waffle version (mix deps): 1.1
• Waffle dependencies when applicable (mix deps): N/A
• Operating system: OSX / Alpine

Expected behavior

I was hoping to use Cloudfront with signed URLs and after configuring it in AWS, I confirmed it just works with both the Cloudfront URL and alternate domain I configured in Cloudfront by just changing the host of the URL generated by waffle/ex_aws:

App.Uploads.ProfilePhoto.url(:thumb, signed: true)
|> String.replace(
  "https://s3.eu-west-2.amazonaws.com/my-bucket-name/",
  "https://dhb50ml2ixxxx.cloudfront.net/"
)

I expected this to just happen if I was to configure the asset_host

Is there a better way to do this than add my own wrapper that changes the url?

Actual behavior

Generating a signed URL always returns a S3 URL

[darwin67]

Same here. Would be nice that the asset_host is respected when using signed URLs.

[JacobAlexander]

bump, it is almost 2years and the issue still exist

[achempion]

My main concern is that some of the deployments can rely on existing logic, and it could break signed URLs for those who don't use Cloudfront for the asset host. I'm thinking about introducing signed_asset_host option that would work similarly to asset_host but used only for signed URLs. Please let me know your thoughts on this

[tomasz-tomczyk]

Perhaps it could be a separate option for now but whenever you're considering a major release bump, it could become the norm? Appreciate it's not big enough thing to warrant a major release now.

Major version releases normally come with potential breaking changes so IMHO it's OK when you do eventually come around to it.