Repository navigation
Localize React Studio Preview and packaged modules - #8957
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 288 files, which is 138 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 288
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
Member
Author
|
@coderabbitai review |
|
Contributor
 [Medium impact] No outstanding findings block merging the reviewed head. SummaryAdds shared English/Dutch translations to React Studio Preview and packaged modules.
The six earlier localization threads remain addressed, as established in the prior review; none is repeated here. sfmskywalker acknowledged that arbitrary callback and message-dictionary data-flow analysis remains outside the catalog check’s documented scope; the reported visible strings were translated, and direct JSX, heading, and toast checks were added. No new actionable issue was found. No additional tests were run for this review. Reviews (9) · Last reviewed commit: "Merge branch 'codex/8859-react-studio-te..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
sfmskywalker
marked this pull request as ready for review
October 21, 2026 04:20
…studio-localization
Member
Author
|
@greptileai Please review integrated head f86122d after the current-main merge. |
…studio-localization # Conflicts: # studio/react/packages/sdk/src/designer/model/data-flow.ts
…studio-localization
…studio-localization
Member
Author
|
@greptileai Please review final integrated head 7ebf114. The latest main is incorporated and the addressed findings are verified and resolved. |
…studio-localization
Member
Author
|
@greptileai Please review pushed head d65c9e8. All six latest findings have independently verified fixes and resolved threads, with208unit/28host/49browser checks passing locally. |
…studio-localization # Conflicts: # studio/react/packages/sdk/src/designer/model/data-flow.ts
Member
Author
|
@greptileai Please review pushed head 90cd534. Runtime-valid expression aliases/usage indexing and live-culture cached call-graph warnings are fixed with independently verified regressions; all three latest threads are resolved. |
…studio-localization
Member
Author
|
@greptileai Please review pushed head 2f0b69c. The only new change is the browser assertion using the valid getCustomer() accessor; product aliases, usage tracking and live-culture warning fixes are unchanged. All five hosted expression browser cases pass and global review threads are resolved. |
…studio-localization
Member
Author
|
@greptileai Please review pushed head 288bcc3. The assignment/read-usage finding is fixed per property occurrence with regressions preserving self-read RHS and equality. Its thread is independently verified/resolved;227unit and production build pass. |
Member
Author
|
@greptileai Please review pushed head 9f38c35. Compound/update variable usage, serialized picker references, and emitted generic getter round-trips are fixed with regressions. Validation messages translate when rendered while drafts and server diagnostics are preserved. Both latest threads are verified/resolved; full294unit/lint/types/catalog/boundary checks pass. Inherited sibling-scope attribution is tracked separately in #8978. |
…studio-localization
Member
Author
|
@greptileai Please review pushed head 92d40bd. The only new change explicitly removes the single test cursor marker using slices rather than replace, preserving all expression content and avoiding the CodeQL false-positive escaping heuristic. Product code is unchanged from the reviewed operator/typed-reference/live-validation fixes. All review threads are verified and resolved. |
20 of 24 tasks
Member
Author
|
User-authorized self-review for #8859. APPROVE + HIGH @ 92d40bd Reviewed 1,217 English/Dutch messages, per-user persisted culture, live cached graph warning/count translation, live module-contributed translations and localization checks. Public SDK translation support and generated module consumption are included; no complete parity beyond the documented checklist is claimed. The final adaptation passes 294 unit, 28 hosting and 49 browser tests, lint/types, module-boundary and localization checks, and builds for net8/net9/net10. The final six findings and subsequent expression-alias/index and cached-culture findings were fixed with regression coverage before this merge. At merge time, current-head CI is green, Greptile is 5/5 on this exact head, and the exhaustive stack thread audit records zero unresolved findings. This is an author self-review under the task owner's explicit standing self-review/self-merge authority, not an independent approval. Use the standard head-matched merge into main without changing protection or using an admin bypass. Final review corrections include compound reads/writes, typed variable/input payloads, escaped generated getter labels, and live client-validation translations with preserved unsaved state. Full unit suite: 294 passing; lint/types, 1,217-message catalogs and 257-file module boundary checks pass. The final test-only correction makes artificial cursor-marker removal explicit for CodeQL without changing product bytes. Full 49 browser scenarios passed before it, and all five expression browser cases passed afterward. No security alert was suppressed. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds live English/Dutch localization for React Studio Preview (#8855, part of #8859). This replaces hard-coded interface copy with 1,213 checked messages and a shared i18next instance rather than introducing another localization mechanism. Matching nonempty Blazor Dutch translations are reused; React-only messages are translated in the SDK catalog.
The header saves the selected culture per API URL and authenticated subject. Switching language updates interface copy, metadata, formatting and completion descriptions while preserving the open editor, selected activity, unsaved workflow names and expressions. Modules contribute transactional, isolated translation namespaces with English fallback; the generated module demonstrates both languages without resetting widget state.
The public SDK additions are optional and additive. A real development React StrictMode regression verifies that query caches survive effect replay and clear on true unmount, supplementing the existing production browser cases. Catalog validation rejects missing/empty messages, interpolation mismatches and raw JSX display strings.
Validation: 151 unit tests, 25 ASP.NET host tests, 44 hosted browser cases, lint, type checking, catalog and module boundaries, production asset build and .NET 8/9/10 builds. Packed npm consumer compile/SSR, TypeDoc, and a fresh generated module using four npm tarballs plus 18 locally packed 3.11.0-preview.8855 NuGet packages passed. The template check switches English/Dutch while retaining widget state, edits/saves activity settings, verifies read-only behavior and checks disabled assets return 404. Dependency audit reports zero known vulnerabilities. Local proof packages have not been published.
Stacked on #8954 and ready for independent Elsa 3 review. Merge requires approval at the current full head SHA. Runtime backend messages and user-authored data are preserved rather than translated by the client.
Live culture regression coverage includes both log-count selectors, task notices translated when a delayed response arrives, and BPMN client refusal explanations while preserving original user titles and server diagnostics.