Skip to content

Get correct install package name#318

Merged
jcs090218 merged 8 commits into
emacs-eask:masterfrom
joshbax189:fix/install-package-name
Apr 4, 2025
Merged

Get correct install package name#318
jcs090218 merged 8 commits into
emacs-eask:masterfrom
joshbax189:fix/install-package-name

Conversation

@joshbax189

Copy link
Copy Markdown
Contributor

This fixes a few bugs in install-file. Some of them are:

  • can install from pacakge.tar and package.tar.gz
  • ignore package.el metadata errors when installing (i.e. treat package-install-file like package-install)
  • package name given to eask-package-install-file matches what package.el reports, so
    • packages in folders with different names install correctly, e.g. foo-0.0.1/foo-pkg.el

See extra tests cases in test/jest/install.test.js

@jcs090218

Copy link
Copy Markdown
Member

Very nice! My first implementation was a bit lazy due to my busy schedule. 🥲 I appreciate you for taking care of this! 🚀🥳

@joshbax189

Copy link
Copy Markdown
Contributor Author

No worries 👍

@jcs090218
jcs090218 merged commit 275dab4 into emacs-eask:master Apr 4, 2025
@jcs090218

Copy link
Copy Markdown
Member

Merged! Thank you!! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants