Conversation
When serverTxRequest triggers a dial, all other transactions were blocked until the dial completed (by a lock on the transactionStore). If the dial fails due to timeout or is otherwise slow, unrelated transactions are blocked. Fix by using transactionStore's existing get/put and using a singleflight.Group to guarantee only a single transaction is created per key. Add TestTransactionLayerServerTxCreationDoesNotBlockOtherTransactions which verifies that different transaction keys are handled independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serverTxRequest triggers a dial, all other transactions were blocked until the dial completed (by a lock on the transactionStore). If the dial fails due to timeout or is otherwise slow, unrelated transactions can blocked long enough
to cause errors on those transactions.
Fix by using transactionStore's existing get/put and using a singleflight.Group to guarantee only a single transaction is created per key.
Add TestTransactionLayerServerTxCreationDoesNotBlockOtherTransactions which verifies that different transaction
keys are handled independently.