Skip to content
This repository was archived by the owner on Aug 4, 2026. It is now read-only.

Support Rails 8.1 routing keywords - #1

Closed
kamal wants to merge 2 commits into
release-0-9from
agent/rails-8-1-support
Closed

Support Rails 8.1 routing keywords#1
kamal wants to merge 2 commits into
release-0-9from
agent/rails-8-1-support

Conversation

@kamal

@kamal kamal commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • pass route option hashes as keywords to Rails mapper APIs
  • pass route options as keywords to Rails internal resource objects
  • cover both singleton and collection JSON:API routes

Verification

  • Ruby syntax check passes
  • Envoy app boot and full Rails 8.1 CI provide integration coverage

The upstream release branch test harness itself does not initialize a Rails 8.1 application before loading rails/test_help, so its legacy standalone routing test cannot run unchanged on Rails 8.1.

@datadog-staging-envoy

datadog-staging-envoy Bot commented Aug 4, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 4 Pipeline jobs failed

CI | Ruby 2.6.6 Rails 6.0.3.4   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger at /opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.7/lib/active_support/logger_thread_safe_level.rb:16

CI | Ruby 2.6.6 Rails 6.1.1   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger in active_support/logger_thread_safe_level.rb

CI | Ruby 2.7.2 Rails 6.0.3.4   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger at /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/activesupport-6.0.3.7/lib/active_support/logger_thread_safe_level.rb:16

View all 4 failed jobs.

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: agent/rails-8-1-support

CI | Ruby 2.6.6 Rails 6.0.3.4
Commit: 1a2d38fed4de137a5501eb20aec8916c74c18468
Error (code / test):
NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger at /opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.7/lib/active_support/logger_thread_safe_level.rb:16
CI job: https://github.com/envoy/jsonapi-resources/actions/runs/30942192112/job/92103144594

CI | Ruby 2.6.6 Rails 6.1.1
Commit: 1a2d38fed4de137a5501eb20aec8916c74c18468
Error (code / test):
NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger in active_support/logger_thread_safe_level.rb
CI job: https://github.com/envoy/jsonapi-resources/actions/runs/30942192112/job/92103144462

CI | Ruby 2.7.2 Rails 6.0.3.4
Commit: 1a2d38fed4de137a5501eb20aec8916c74c18468
Error (code / test):
NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger at /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/activesupport-6.0.3.7/lib/active_support/logger_thread_safe_level.rb:16
CI job: https://github.com/envoy/jsonapi-resources/actions/runs/30942192112/job/92103144560

Plus 1 more failing job not shown here.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1a2d38f | Docs | Datadog PR Page | Give us feedback!

@kamal kamal closed this Aug 4, 2026
@kamal
kamal deleted the agent/rails-8-1-support branch August 4, 2026 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant