Conversation
--zero is documented to end each output entry with a NUL byte, but the Zero printer wrote each entry's content and never wrote \x00, so consecutive entries concatenated with no delimiter and consumers could not safely split the stream. Write one NUL byte after every entry. A single entry is still terminated, so a reader does not block waiting for a delimiter that never arrives. Fixes equationzhao#333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--zerois meant to end each output entry with a NUL byte, but theZeroprinter wrote each entry's content and never wrote\x00, so entries concatenated with no delimiter and the stream couldn't be split safely.Fixes #333.
Repro
Two files
a,bin a dir:Before:
After:
Change
internal/display/printer.go— write one NUL byte after every entry inZero.Print. A single entry is still terminated, so a reader doesn't block waiting for a delimiter that never comes.Tests
internal/display/zero_test.go—TestZeroPrinterTerminatesEachEntryWithNULasserts the exact streama\x00b\x00c\x00, andTestZeroPrinterSingleEntryStillTerminatedcovers the single-entry case. Both fail on the pre-fix code (onlyvsonly\x00).go test ./internal/display/...passes;gofumpt --extra -w -l .clean.