Add editable axis/title labels from plot by MagnusSletten · Pull Request #13992 · equinor/ert

MagnusSletten · 2026-07-13T11:04:13Z

Issue
Resolves #13999
Resolves #14006

Approach
Enable picking on the x- and y-axis labels and plot title after each render, and handle Matplotlib pick events on the canvas. Selecting one opens a pre-filled input dialog. Accepted changes are stored in the active key’s PlotConfig history and applied immediately through the existing refresh mechanism. Clearing the input restores the default text.

Also removes the axis-label and title controls from the customization style tab.

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

Copilot

Pull request overview

Enables in-plot editing of Matplotlib axis labels in the ERT GUI by making axis label artists pickable, emitting a Qt signal when a label is clicked, and opening an edit dialog in the plot window that persists changes via the active PlotConfig history.

Changes:

Add pick handling in PlotWidget to detect clicks on x/y axis label artists and emit an edit-request signal.
Add an edit flow in PlotWindow using QInputDialog, applying accepted label changes via PlotCustomizer.
Allow PlotConfig x/y label setters to accept None, and add unit tests covering the new signal + config update behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/ert/unit_tests/gui/tools/plot/test_plot_window.py	Adds unit tests for axis-label click signal emission and `PlotCustomizer.set_axis_label()` updating `PlotConfig`.
src/ert/gui/plotting/widgets/plot_widget.py	Connects Matplotlib `pick_event`, enables picking for axis labels, and emits `axisLabelEditRequested`.
src/ert/gui/plotting/utils/plot_config.py	Updates x/y label setters to accept `str
src/ert/gui/plotting/plot_window.py	Listens for `axisLabelEditRequested` and opens a pre-filled input dialog to edit/apply axis labels.
src/ert/gui/plotting/customization_dialog/customize_plot_dialog.py	Adds `PlotCustomizer.set_axis_label()` to write label changes into `PlotConfigHistory` and refresh customization UI state.

codecov-commenter · 2026-07-13T11:22:35Z

Codecov Report

❌ Patch coverage is 86.81319% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.57%. Comparing base (d74abf8) to head (a80187d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
.../plotting/widgets/plot_controls/general_options.py	66.66%	9 Missing ⚠️
src/ert/gui/plotting/plot_window.py	94.87%	2 Missing ⚠️
...ting/customization_dialog/customize_plot_dialog.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13992      +/-   ##
==========================================
- Coverage   91.63%   91.57%   -0.07%     
==========================================
  Files         487      487              
  Lines       34380    34451      +71     
==========================================
+ Hits        31505    31549      +44     
- Misses       2875     2902      +27

Flag	Coverage Δ
cli-tests	`35.71% <0.00%> (-0.09%)`	⬇️
fuzz	`43.51% <15.38%> (-0.07%)`	⬇️
gui-tests	`59.02% <39.56%> (-0.12%)`	⬇️
performance-and-unit-tests	`80.16% <86.81%> (-0.03%)`	⬇️
test	`45.81% <15.38%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...g/customization_dialog/style_customization_view.py	`89.28% <ø> (+4.84%)`	⬆️
src/ert/gui/plotting/widgets/plot_widget.py	`88.72% <100.00%> (+2.11%)`	⬆️
...ting/customization_dialog/customize_plot_dialog.py	`81.54% <75.00%> (+0.67%)`	⬆️
src/ert/gui/plotting/plot_window.py	`80.04% <94.87%> (+1.72%)`	⬆️
.../plotting/widgets/plot_controls/general_options.py	`89.24% <66.66%> (-9.29%)`	⬇️

... and 5 files with indirect coverage changes

codspeed-hq · 2026-07-13T12:03:21Z

Merging this PR will not alter performance

✅ 36 untouched benchmarks

_{Comparing MagnusSletten:axis-name (a80187d) with main (d74abf8)}

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

ertomatic · 2026-07-15T06:45:31Z

Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#52

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

eilskra · 2026-07-17T10:20:26Z

Could we also add two buttons (Change x-label, Change y-label) to GeneralOptions that trigger same pop-up window?
Then we can remove it from CustomizationWidget 👍

MagnusSletten · 2026-07-17T10:33:34Z

Could we also add two buttons (Change x-label, Change y-label) to GeneralOptions that trigger same pop-up window?
Then we can remove it from CustomizationWidget 👍

Sounds good! I'll do that. Sidenote: also noticed that the Limits tab looks awkward in customization widget, the text boxes are unnaturally tall.

eilskra · 2026-07-17T10:38:50Z

@MagnusSletten

Sidenote: also noticed that the Limits tab looks awkward in customization widget, the text boxes are unnaturally tall.

Think the formatting is due to how its set initially. In general, the customization widget has a lot of issues, so I think we should have a move limits to GeneralOptions

I think I would split this PR in two, labels and limits, to prevent scope creep now that we can add more buttons. If we finish labels with this PR, then we can repeat the axis-click + additional buttons + customization widget field/tab removal, but for limits

Edit: Could prob add title too?

MagnusSletten · 2026-07-17T10:46:06Z

I think I would split this PR in two, labels and limits, to prevent scope creep now that we can add more buttons. If we finish labels with this PR, then we can repeat the axis-click + additional buttons + customization widget field/tab removal, but for limits

I agree! I'll just move that limit related commit then.

eilskra · 2026-07-21T10:56:13Z

+        self.update_plot_config(plot_config)

+    def update_plot_config(self, plot_config: PlotConfig) -> None:
+        history = self._get_plot_config_history()
+        history.apply_changes(plot_config)
        self._emit_changed_signal()


This was a temp solution needed before removal of the CustomizationDialog or could this be skipped?

It's like this to keep current per key plotting behaviour so that changes for titles remain when clicking between keys.

eilskra · 2026-07-21T10:57:54Z

+        self._change_x_label = QPushButton("Edit x-label")
+        self._change_x_label.setObjectName("change_x_label_button")
+        self._change_x_label.clicked.connect(
+            lambda: self.axisLabelEditRequested.emit("x")
+        )
+
+        self._change_y_label = QPushButton("Edit y-label")
+        self._change_y_label.setObjectName("change_y_label_button")
+        self._change_y_label.clicked.connect(
+            lambda: self.axisLabelEditRequested.emit("y")
+        )
+
+        self._change_title = QPushButton("Edit title")
+        self._change_title.setObjectName("change_title_button")
+        self._change_title.clicked.connect(self.titleEditRequested.emit)


Could we reduce the duplication of code somehow? If fix leads to unnecessarily difficult to read code, then skip

Can absolutely be done 👍

Done in recent commit

eilskra · 2026-07-21T11:03:57Z

Could you add a couple of screenshots to display functionality and buttons?

eqbech · 2026-07-21T12:47:09Z

It is not obvious to me that it is possible to click on the axis labels and title to edit them. Is there an easy way to add some effect or something similar that shows that these are editable by clicking on them? E.g changing fontsize when hovered or background color or cursor type on hover etc.

MagnusSletten · 2026-07-21T12:48:54Z

It is not obvious to me that it is possible to click on the axis labels and title to edit them. Is there an easy way to add some effect or something similar that shows that these are editable to clicking on them? E.g changing fontsize when hovered or background color or cursor type on hover etc.

Good point! Maybe actually this can be in a smaller separate PR? I will have an upcoming one for the limits as well.

Users need a direct way to customize the x and y axis labels from the plot.

eilskra · 2026-07-21T13:53:37Z

+        self._change_x_label = create_edit_button(
+            "x-label",
+            lambda: self.axisLabelEditRequested.emit("x"),
+        )
+        self._change_y_label = create_edit_button(
+            "y-label",
+            lambda: self.axisLabelEditRequested.emit("y"),
+        )
+        self._change_title = create_edit_button(
+            "title",
+            self.titleEditRequested.emit,
+        )
+
+        edit_buttons = QWidget()
+        edit_buttons_layout = QHBoxLayout(edit_buttons)
+        edit_buttons_layout.setContentsMargins(0, 0, 0, 0)
+
+        for button in (
+            self._change_x_label,
+            self._change_y_label,
+            self._change_title,
+        ):
+            edit_buttons_layout.addWidget(button)
+


for label, func in [ ("x-label", lambda: self.axisLabelEditRequested.emit("x")) ...]: edit_buttons_layout.addWidget(create_edit_button(label, func)

Much better, done! 👍

eilskra

Just had one refactor comment, bar that LGTM

MagnusSletten force-pushed the axis-name branch from 0c4e18f to 02f51e8 Compare July 13, 2026 11:08

MagnusSletten requested a review from Copilot July 13, 2026 11:10

Copilot started reviewing on behalf of MagnusSletten July 13, 2026 11:10 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/ert/gui/plotting/plot_window.py Outdated

MagnusSletten requested a review from Copilot July 13, 2026 12:05

Copilot started reviewing on behalf of MagnusSletten July 13, 2026 12:05 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

MagnusSletten marked this pull request as ready for review July 13, 2026 12:12

MagnusSletten force-pushed the axis-name branch from e6ce363 to 02121ae Compare July 13, 2026 12:17

MagnusSletten added this to SCOUT Jul 14, 2026

MagnusSletten moved this to In Progress in SCOUT Jul 14, 2026

MagnusSletten force-pushed the axis-name branch from 02121ae to b95cfd0 Compare July 15, 2026 06:37

ertomatic mentioned this pull request Jul 15, 2026

Update screenshots for equinor/ert#13992 equinor/ert-testdata#52

Closed

MagnusSletten requested a review from Copilot July 15, 2026 11:10

Copilot started reviewing on behalf of MagnusSletten July 15, 2026 11:10 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

MagnusSletten changed the title ~~Add editable axis labels from plot~~ Add editable axis labels and limits from plot Jul 15, 2026

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 15, 2026

Update screenshots for equinor/ert#13992

e77b366

eilskra removed this from SCOUT Jul 15, 2026

eilskra assigned MagnusSletten Jul 15, 2026

eilskra added the improvement Something nice to have, that will make life easier for developers or users or both. label Jul 15, 2026

MagnusSletten force-pushed the axis-name branch 2 times, most recently from 0295a76 to 8ca5c7b Compare July 17, 2026 06:59

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

e500e5a

eilskra reviewed Jul 21, 2026

View reviewed changes

MagnusSletten force-pushed the axis-name branch from 786c64a to 13a8176 Compare July 21, 2026 11:51

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

6e96b4d

MagnusSletten force-pushed the axis-name branch 2 times, most recently from 23d3daa to c5cb2ea Compare July 21, 2026 12:18

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

137cf21

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

1f43912

eqbech mentioned this pull request Jul 21, 2026

Add some effect to the editable labels #14007

Closed

MagnusSletten added 6 commits July 21, 2026 14:53

Add axis label editing

37408f6

Users need a direct way to customize the x and y axis labels from the plot.

Add axis label controls to general options

e7212dd

Add plot title editing

5d7db8f

Add title editing to general options

bd009b7

Extract shared plot text dialog

37a860f

Refactor plot-window label tests

b3c3940

MagnusSletten force-pushed the axis-name branch from c5cb2ea to b3c3940 Compare July 21, 2026 12:58

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

83bb125

MagnusSletten requested a review from eilskra July 21, 2026 13:22

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

9e3ce30

eilskra reviewed Jul 21, 2026

View reviewed changes

Refactor GeneralPlotOptions

a80187d

MagnusSletten force-pushed the axis-name branch from c7a2265 to a80187d Compare July 21, 2026 13:58

eilskra approved these changes Jul 21, 2026

View reviewed changes

MagnusSletten enabled auto-merge (rebase) July 21, 2026 14:05

ertomatic pushed a commit to equinor/ert-testdata that referenced this pull request Jul 21, 2026

Update screenshots for equinor/ert#13992

3e81ed6

MagnusSletten merged commit 20cb24b into equinor:main Jul 21, 2026
30 checks passed

eilskra removed the improvement Something nice to have, that will make life easier for developers or users or both. label Jul 21, 2026

Uh oh!

Conversation

MagnusSletten commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

When applicable

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov-commenter commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

ertomatic commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

eilskra commented Jul 17, 2026

Uh oh!

MagnusSletten commented Jul 17, 2026

Uh oh!

eilskra commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MagnusSletten commented Jul 17, 2026

Uh oh!

Uh oh!

Uh oh!

eilskra Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

MagnusSletten Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

eilskra Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

MagnusSletten Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

MagnusSletten Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eilskra commented Jul 21, 2026

Uh oh!

eqbech commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MagnusSletten commented Jul 21, 2026

Uh oh!

eilskra Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

MagnusSletten Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eilskra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

MagnusSletten commented Jul 13, 2026 •

edited

Loading

codecov-commenter commented Jul 13, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 13, 2026 •

edited

Loading

eilskra commented Jul 17, 2026 •

edited

Loading

eqbech commented Jul 21, 2026 •

edited

Loading

MagnusSletten Jul 21, 2026 •

edited

Loading