Skip to content

Add the #3282 CHANGELOG entry - #3337

Merged
erikdarlingdata merged 1 commit into
devfrom
chore/changelog-3282
Sep 12, 2026
Merged

Add the #3282 CHANGELOG entry#3337
erikdarlingdata merged 1 commit into
devfrom
chore/changelog-3282

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Adds the [Unreleased] / ### Fixed entry for #3282, whose fix merged as #3328 (98c551af, storage V118). Lane PRs do not edit CHANGELOG.md, so the entry is spliced separately.

Two inserted lines: the entry at the top of ### Fixed and the [#3282] link definition. Anchored on the first ### Fixed at or after the [Unreleased] marker and asserted to land before ## [3.7.0], since the block opens with ### Added. CRLF preserved, zero bare LF.

@claude

claude Bot commented Sep 11, 2026

Copy link
Copy Markdown

Reviewed. This is a CHANGELOG-only PR (one file, two inserted lines: the ### Fixed entry and its [#3282] link definition), so most of the usual review dimensions (T-SQL style, Lite/Darling code parity, SQL injection/security, performance) don't apply — there's no code here.

Checked the entry's claims against the actual #3328 implementation and they hold up:

  • AlertPersistenceGate (PerformanceMonitor.Alerting/AlertPersistenceGate.cs) is the shared, host-agnostic primitive both evaluators use.
  • Lite's SQL Server path (AlertEngine.cs) and Darling's PostgreSQL path (DarlingWorker.cs, PostgresAlertEvaluator) both call AlertPersistenceGate.Evaluate with 3 breach / 2 clear samples, confirming "both engines"/"both SKUs" in the text.
  • Streak counting is per collected sample (not per sweep), and state is persisted per server, matching the "a re-read of one reading cannot fill the streak" and restart-safety claims.
  • The missing-reading freeze behavior (no observation ≠ a clearing observation) matches the code comments in AlertEngine.cs around the CPU resolve arm.

Formatting/placement:

  • New bullet is the first item under the existing ## [Unreleased]### Fixed heading, consistent with how other entries in this release were stacked (newest on top).
  • [#3282] link definition added at the end of the reference-link block, no duplicate definition, and the file's CRLF line endings are preserved (confirmed via file — no mixed line-ending warning).
  • Bullet style (bold summary, ([#issue]), - prose) matches the surrounding entries.

No issues found. LGTM.

@erikdarlingdata
erikdarlingdata merged commit 0135421 into dev Sep 12, 2026
8 checks passed
@erikdarlingdata
erikdarlingdata deleted the chore/changelog-3282 branch September 12, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant