Conversation
…of total length + fix comment length extraction
… and annotation segregation
…dling, add unit test
…onformanceChecker class
…, return value in DD, add test sample
…er, add unit tests for KB
…t tests with disclosures
…ent signature structure types
(cherry picked from commit 10fa4884bdd5803ff1f21f5ea5d4869ce768d0bb)
Merged
…nsFinder, add /Lock and /SV dictionaries for comparison (cherry picked from commit 041195f27298b572328f4ef1bba70b5aa2310c20)
(cherry picked from commit 09637d0162c83bed334b5cf46e823ecbabc52057)
Contributor
Author
|
Edit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are applied:
PdfSigDictWrappermade to containList<PdfSignatureFields>directly, thus simplifying the logic of interfaces;PdfDocumentReader#extractSigDictionariesnow return a list ofPdfSigDictWrapper's instead of a map betweenPdfSigDictWrapperandList<PdfSignatureFields>thanks to the change above;PdfSigDictWrapper#checkConsistencycheck reverted to request onlyPdfSignatureDictionaryas an input;PdfSigDictWrapper#checkConsistencynow performs comparison over the selected signature fields,which means all entries are compared,including the signature dictionary /V;/Pand/Parent. Only the top indirect reference is compared./AcroFormentries.All tests now pass with the change. The current PR will be included in DSS 6.6 branch, while some minor adaptations are to be done for DSS 6.5, such as we would evaluate only the essential fields such as
/Rectangleand/APto avoid unexpected regression just before the release.