Skip to content

PR#194 review - #195

Open
bsanchezb wants to merge 55 commits into
masterfrom
PR#194
Open

PR#194 review#195
bsanchezb wants to merge 55 commits into
masterfrom
PR#194

Conversation

@bsanchezb

@bsanchezb bsanchezb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The following changes are applied:

  • PdfSigDictWrapper made to contain List<PdfSignatureFields> directly, thus simplifying the logic of interfaces;
  • PdfDocumentReader#extractSigDictionaries now return a list of PdfSigDictWrapper's instead of a map between PdfSigDictWrapper and List<PdfSignatureFields> thanks to the change above;
  • PdfSigDictWrapper#checkConsistency check reverted to request only PdfSignatureDictionary as an input;
  • PdfSigDictWrapper#checkConsistency now performs comparison over the selected signature fields, which means all entries are compared, including the signature dictionary /V;
  • Nested validation for some entries are skipped, such as /P and /Parent. Only the top indirect reference is compared.
  • OpenPdf implementation has been fixed, to return the actual representation of a signature field, instead of merging it with /AcroForm entries.

All tests now pass with the change. The current PR will be included in DSS 6.6 branch, while some minor adaptations are to be done for DSS 6.5, such as we would evaluate only the essential fields such as /Rectangle and /AP to avoid unexpected regression just before the release.

bsanchezb and others added 30 commits July 3, 2026 15:29
…of total length + fix comment length extraction
axelabinet and others added 22 commits July 16, 2026 10:09
(cherry picked from commit 10fa4884bdd5803ff1f21f5ea5d4869ce768d0bb)
@bsanchezb bsanchezb mentioned this pull request Aug 7, 2026
…nsFinder, add /Lock and /SV dictionaries for comparison

(cherry picked from commit 041195f27298b572328f4ef1bba70b5aa2310c20)
(cherry picked from commit 09637d0162c83bed334b5cf46e823ecbabc52057)
@bsanchezb

Copy link
Copy Markdown
Contributor Author

Edit:

  • Moved logic to a new PdfSignatureDictionaryModificationsFinder class;
  • Improved PdfObjectModificationsFilter to distinguish between modifications in existing signatures/timestamps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants