Repository navigation
Conversation
|
@adeshi105 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…os-protocol#560) CI reads the baseline from ANDROID_BASE_SIZE_MB and IOS_BASE_SIZE_MB, so the 5% regression check runs. A build on main with no baseline fails with a clear message. Tests cover growth over and under the threshold. Closes ethos-protocol#560 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…hos-protocol#531) Refs ethos-protocol#557, ethos-protocol#558: the same scheduled failure. Its cause is only in the run log, so this change does not confirm a fix for those. Closes ethos-protocol#531 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…l#558) Refs ethos-protocol#557. The failed scheduled runs only show their cause in the log, so the output is uploaded on every run. This does not yet confirm the cause. Refs ethos-protocol#558 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-size baseline, dependency scan limits, and scan output
ANDROID_BASE_SIZE_MBandIOS_BASE_SIZE_MB, so the 5% check runs. A main build without a baseline fails with a clear message. A test covers growth over and under the threshold (Pass a Real Baseline to the Build-Size Tracker in CI #560). The two repository variables still need to be set.NVD_API_KEYwhen that secret is set (⚠️ Android dependency-check failed (scheduled scan) #531). This addresses the hang documented in Android: deadVaultWebSocketClientstub duplicates the real, wiredVaultEventSocket#178. It has not been confirmed against a failing run.Refs #557: the same scheduled-scan failure as #531 and #558. The cause is in the run logs, which were not available, so it is referenced and not closed.
Refs #558: the scan output upload above is the scaffold for reading that cause. It is not a confirmed fix.
Closes #560
Closes #531
🤖 Generated with Claude Code
Closes #557
Closes #558