Repository navigation
Staging smoke test and app-link script hardening (#569-#572) - #675
Open
chiamaka105 wants to merge 5 commits into
Open
chiamaka105 wants to merge 5 commits into
chiamaka105 wants to merge 5 commits into
Conversation
|
@chiamaka105 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…thos-protocol#569) Closes ethos-protocol#569 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
SMOKE_PLATFORMS sets the list, and defaults to ios and android. Closes ethos-protocol#570 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…tocol#571) Closes ethos-protocol#571 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…N is set (ethos-protocol#572) Closes ethos-protocol#572 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…otocol#572) Closes ethos-protocol#572 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging smoke test and app-link script hardening
mktemp -ddirectory, removed on exit (Replace the Fixed/tmpOutput Paths in the App-Link Verification Scripts #569)SMOKE_PLATFORMS(defaultios android) (Stop Hardcoding"platform": "ios"in the Smoke Test's Push Probe #570)DELETE /notifications/registerafter its probe (Unregister Dummy Push Tokens Created by the Staging Smoke Test #571)STAGING_SMOKE_ALLOW_CHECKIN=1, so the default run does not extend a shared vault's TTL (Stop the Staging Smoke Test From Mutating a Shared Vault's TTL #572). The check-in is still available to run against a dedicated vault. Creating and deleting that vault in setup and teardown is not done.Note: #568 (aremu's PR) changes the same smoke script. Expect a small merge conflict on the
/tmp/smoke_body.jsonlines when both are merged.Closes #569
Closes #570
Closes #571
Refs #572 (partial, see above)
🤖 Generated with Claude Code
Closes #572