Repository navigation
fix(ui): break the test history chart lines at gaps between runs - #361
Conversation
The MGas/s chart of a test history did not match the runs table in two ways: - The chart hid the symbols of all clients when one client had more than 30 runs. With 54 geth runs, the 4 besu runs looked like one continuous line. Each client line now hides its symbols only when it has more than 30 runs itself. - A line joined two runs across a gap of days, so it looked like a slow trend with no runs in it. On the time axis, a line now breaks where the gap is 5x the median interval of the client and at least 6 hours. A run with a gap on both sides shows as a dot.
A client line hid its dots above 30 runs, so the 54 geth runs of a test showed as a plain line. A line now shows small dots up to 100 runs, the default runs per client, and hides them only above that. The x axis now opens on Run #. It spaces the runs evenly, so a gap of days between runs does not squeeze the recent runs into a corner. The time axis stays one click away, with ?x=time in the URL.
This comment has been minimized.
This comment has been minimized.
CI failed @
|
There was a problem hiding this comment.
The PR makes the test-history chart show per-client dots up to 100 runs (small above 30), break lines at time-axis gaps of at least 5× the median interval and 6 hours, render isolated runs via a same-named scatter series when symbols are hidden, and default the x axis to Run # with ?x=time for the time axis. I traced the gap-index/isolated-point logic, the oldest-first ordering contract with buildHistoryPoints, the dense-vs-large threshold split, and the URL param flip, and verified the gap heuristics with a scratch repro and the new tests — all consistent. No real problems found.
Reviewed 4 changed file(s) @ 69392cfd — no blocking issues found.
"A pessimist is a well-informed optimist." — Hungarian saying
Summary
The MGas/s chart on a test history page did not match the runs table. An example is
test_deploy_then_interact[...greedy_fill-independent_pairs-benchmark-gas-value_200M]in suitea1f2039d3c1dc45d. Each client has one run on Oct 15, then no runs until Oct 20. Geth has 54 runs, and the other clients have 4–10.Fixes
?x=timein the URL. Old links with?x=runCountstill work.Tests
findRunGaps: a gap of days between runs every few hours, a steady daily series, a short gap between frequent runs, and a series with only one interval.xparam in the URL.