fix(pattern): correct cross-chain atomicity claims in ERC-7573 cards - #198
Merged
Conversation
The private PvP card finalised the paying leg, then claimed both escrows revert on failure and atomic settlement without time-locks. A settled payment cannot revert. Rewrite the recipe to the ERC-7573 shape: one leg locked, the other paid through the decryption contract, and an oracle key that releases or returns the locked leg. State the guarantee as conditional on the oracle. The DvP card offered a timeout reclaim that ERC-7573 does not define and that can fire after the buyer has paid. The permissioned-ledger card said a malicious coordinator can only stall; under two-phase commit it can split the outcome.
rymnc
reviewed
Sep 11, 2026
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Co-authored-by: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private PvP card claimed "both legs settle or both revert, without relying on time-locks for safety." Its own recipe finalised the paying leg first (step 3) and then said both escrows revert on failure (step 6). A settled payment can't revert. Step 2 also had each escrow wait on the other leg, which can't release either.
What changes
Other sources: the authors' paper (arXiv 2311.05966), Zamyatin et al. on why cross-chain atomicity needs a trusted party or synchrony, and Gray and Lamport.
Checks
validate-patterns.jsandcheck-terminology.jspass in strict mode.