Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
+ Coverage 81.16% 82.27% +1.10%
==========================================
Files 75 80 +5
Lines 6399 6844 +445
==========================================
+ Hits 5194 5631 +437
- Misses 1205 1213 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haeter525
self-requested a review
January 24, 2026 14:56
haeter525
requested changes
Jan 28, 2026
haeter525
reviewed
Jan 28, 2026
sidra-asa
force-pushed
the
dextrace_core
branch
from
February 10, 2026 02:38
1469ff7 to
78c6be8
Compare
haeter525
added a commit
that referenced
this pull request
Aug 4, 2026
* feat(dextrace): add DexTrace backend
* perf(dextrace): cache DEX content
* fix(dextrace): wire and fix class hierarchy and subclass BFS
* fix(dextrace): fix smali parsing and class name normalization
* fix(dextrace): fix ZIP loading and permissions
* fix(dextrace): complete call graph with abstract methods
* refactor(dextrace): simplify and deduplicate DexTraceImp
* fix(dextrace): raise ValueError on unreadable AndroidManifest.xml
Replaces the silent get_apk_permissions() call with a direct parse_manifest()
call that raises ValueError when the manifest is missing or has invalid AXML
bytes. trickmo and tanglebot APKs now fail fast (< 1 s) instead of running
three full DEX passes (134 s on trickmo).
parse_manifest() requires DexTrace fix: propagate {"error": ...} from
ManifestParser instead of silently mapping it to empty fields.
Adds two unit tests for the two ValueError paths:
- invalid AXML bytes in AndroidManifest.xml
- AndroidManifest.xml entry absent from the ZIP
* perf(dextrace): drop extra DEX passes and inline local aliases
---------
Co-authored-by: sidra-asa <sasakikung@gmail.com>
Member
|
Close as #958 merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the DexTrace-based apkinfo backend integration.
How to test