Skip to content

fix: defer default rule path validation (#936) - #946

Closed
gitcommit90 wants to merge 1 commit into
ev-flow:masterfrom
gitcommit90:fix/issue-936-rule-default-validation
Closed

gitcommit90 wants to merge 1 commit into
ev-flow:masterfrom
gitcommit90:fix/issue-936-rule-default-validation

Conversation

@gitcommit90

Copy link
Copy Markdown

Summary

  • Remove exists=True from the --rule option so Click does not reject the missing default path during parsing.
  • Existing command logic still validates explicit JSON rule files and walks the rule directory.

Closes #936

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.89%. Comparing base (1df1d49) to head (ef9ea4c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files          81       81           
  Lines        7131     7131           
=======================================
  Hits         5626     5626           
  Misses       1505     1505           
Flag Coverage Δ
unittests 78.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haeter525

Copy link
Copy Markdown
Member

Hi @gitcommit90. thank you for opening the PR!

We're already working on this issue in #937, so I am going to close this PR to avoid duplication. Please feel free to share ideas or leave a comment there. Thanks.

@haeter525 haeter525 closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--rule default path validated even when unused

2 participants