CMake: Handle C++ API dependencies conditionally#412
Open
Growl1234 wants to merge 2 commits into
Open
Conversation
Growl1234
changed the title
Growl1234
changed the title
Contributor
Author
|
👀 |
Growl1234
changed the title
Contributor
Author
|
I've found and fixed another issue regarding CMake configuraion exporting when dealing with downstream consuming. Btw, the PR seem not got attention for already many weeks... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves below problems:
LIBINT2_REQUIRE_CXX_APIis enabled, but the installation of bundled Boost headers is done without requiring C++ API. Therefore, a build withLIBINT2_REQUIRE_CXX_API=OFFmight fail in install stage.LIBINT2_REQUIRE_CXX_API=OFF, Eigen3 and boost are not needed, butlibint2-config.cmakewill find them anyways and might give an unexpected error when consumed downstream.