Skip to content

feat(rg): add config and git ignore controls - #1659

Merged
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-buffering-config
May 22, 2026
Merged

chaliy merged 1 commit into
mainfrom
2026-05-22-rg-buffering-config

Conversation

@chaliy

@chaliy chaliy commented May 22, 2026

Copy link
Copy Markdown
Contributor

What

Add rg parity for --require-git/--no-require-git and accept common real-rg no-op flags --no-config, --line-buffered, and --block-buffered.

Why

Real rg supports these flags, and --no-require-git changes .gitignore behavior outside git repos.

How

Track require_git in rg options, apply .gitignore outside git repos when disabled, and extend the real-rg differential matrix for the behavior and accepted flags.

Risk

  • Low
  • Scoped to rg argument parsing and ignore-file discovery.

Checklist

  • Tests added or updated
  • Backward compatibility considered

Verification:

  • cargo test -p bashkit builtins::rg::tests -- --nocapture
  • just pre-pr

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 40dc0e4 Commit Preview URL May 22 2026, 06:16 AM

@chaliy
chaliy merged commit e3d0501 into main May 22, 2026
34 checks passed
@chaliy
chaliy deleted the 2026-05-22-rg-buffering-config branch May 22, 2026 06:27
chaliy added a commit that referenced this pull request May 30, 2026
## What
Add rg parity for --require-git/--no-require-git and accept common
real-rg no-op flags --no-config, --line-buffered, and --block-buffered.

## Why
Real rg supports these flags, and --no-require-git changes .gitignore
behavior outside git repos.

## How
Track require_git in rg options, apply .gitignore outside git repos when
disabled, and extend the real-rg differential matrix for the behavior
and accepted flags.

## Risk
- Low
- Scoped to rg argument parsing and ignore-file discovery.

## Checklist
- [x] Tests added or updated
- [x] Backward compatibility considered

Verification:
- cargo test -p bashkit builtins::rg::tests -- --nocapture
- just pre-pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant