Repository navigation
fix(rg): handle multiline invert matches - #1665
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | cf7e1e7 | Commit Preview URL | May 22 2026, 08:31 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Fix rg multiline invert matching and expand real-rg differential coverage for multiline edge modes. ## Why Real ripgrep treats lines spanned by a multiline match as matched for `-v`; Bashkit was falling back to per-line matching, so `rg -v -U 'foo\nbar'` printed every line. ## How - Keep the multiline search path active for `--invert-match`. - Build the inverse line set from multiline match spans and use it for output, counts, file-list modes, context, quiet, and stats. - Add data-driven real-rg differential cases for multiline invert, invert count, files-without-match, column/byte offsets, vimgrep, JSON, and stdin. ## Risk - Medium - Touches rg multiline output control flow. Covered by focused rg unit tests, expanded real-rg differential cases, and full pre-pr. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix rg multiline invert matching and expand real-rg differential coverage for multiline edge modes.
Why
Real ripgrep treats lines spanned by a multiline match as matched for
-v; Bashkit was falling back to per-line matching, sorg -v -U 'foo\nbar'printed every line.How
--invert-match.Risk
Checklist