Repository navigation
feat(rg): add case-insensitive glob filters - #1666
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | d53396c | Commit Preview URL | May 22 2026, 08:55 AM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Add rg glob parity for `--iglob`, `--glob-case-insensitive`, and `--no-glob-case-insensitive`; also make multiple glob rules use real ripgrep's last-match-wins precedence. ## Why Bashkit rg supported `-g/--glob`, but did not support case-insensitive glob modes and treated all exclude globs as absolute, which diverged from real rg when later globs overrode earlier ones. ## How - Track glob rule order and resolve the final matching rule per path. - Add case-insensitive glob compilation for `--iglob` and global toggling for normal `-g/--glob` rules. - Match real `rg --files` exit status when filtering leaves no files. - Add data-driven real-rg differential cases for glob precedence, `--iglob`, case-insensitive toggles, and `--files` no-match behavior. ## Risk - Medium - Changes path filtering behavior for rg. Covered by focused rg tests, expanded real-rg differential cases, and full pre-pr. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add rg glob parity for
--iglob,--glob-case-insensitive, and--no-glob-case-insensitive; also make multiple glob rules use real ripgrep's last-match-wins precedence.Why
Bashkit rg supported
-g/--glob, but did not support case-insensitive glob modes and treated all exclude globs as absolute, which diverged from real rg when later globs overrode earlier ones.How
--igloband global toggling for normal-g/--globrules.rg --filesexit status when filtering leaves no files.--iglob, case-insensitive toggles, and--filesno-match behavior.Risk
Checklist