Skip to content

feat(rg): accept diagnostic controls - #1678

Merged
chaliy merged 1 commit into
mainfrom
2026-05-22-rg-batch-4
May 22, 2026
Merged

chaliy merged 1 commit into
mainfrom
2026-05-22-rg-batch-4

Conversation

@chaliy

@chaliy chaliy commented May 22, 2026

Copy link
Copy Markdown
Contributor

What

Add rg parser/help support for --debug, --trace, --no-ignore-messages, --hostname-bin, and --hyperlink-format.

Why

These are real ripgrep flags used by scripts and wrappers. For ordinary searches they should not change stdout, so bashkit can accept them instead of failing.

How

Treat diagnostic and hyperlink-related flags as no-ops, update help output, and add real-rg differential cases proving stdout/exit-code parity.

Risk

  • Low
  • Diagnostic stderr and terminal hyperlink rendering are not modeled; this preserves search stdout behavior.

Checklist

  • Tests added or updated
  • Backward compatibility considered

@chaliy
chaliy marked this pull request as ready for review May 22, 2026 15:13
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 22, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
bashkit 062b033 Commit Preview URL May 22 2026, 03:14 PM

@chaliy
chaliy merged commit fc77a55 into main May 22, 2026
34 checks passed
@chaliy
chaliy deleted the 2026-05-22-rg-batch-4 branch May 22, 2026 15:29
chaliy added a commit that referenced this pull request May 30, 2026
## What
Add rg parser/help support for --debug, --trace, --no-ignore-messages,
--hostname-bin, and --hyperlink-format.

## Why
These are real ripgrep flags used by scripts and wrappers. For ordinary
searches they should not change stdout, so bashkit can accept them
instead of failing.

## How
Treat diagnostic and hyperlink-related flags as no-ops, update help
output, and add real-rg differential cases proving stdout/exit-code
parity.

## Risk
- Low
- Diagnostic stderr and terminal hyperlink rendering are not modeled;
this preserves search stdout behavior.

## Checklist
- [x] Tests added or updated
- [x] Backward compatibility considered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant