Repository navigation
feat(rg): honor parent ignore files - #1684
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | bb0acd5 | Commit Preview URL | May 22 2026, 05:57 PM |
chaliy
added a commit
that referenced
this pull request
May 30, 2026
## What Makes rg seed recursive searches with ignore rules from parent directories. ## Why Real rg honors parent `.ignore`, `.rgignore`, and applicable `.gitignore` files when searching a child root, unless `--no-ignore-parent` is set. Bashkit only loaded ignore files inside the searched root. ## How - Adds parent ignore rule loading before recursive walk roots are queued. - Reuses existing local ignore parsing and git-repository checks. - Preserves `--no-ignore` and `--no-ignore-parent` behavior. - Adds unit and differential coverage against real rg for parent ignore and `--no-ignore-parent`. ## Risk - Low / Medium - Recursive search filtering changes for child roots with parent ignore files; explicit file searches still bypass ignore filtering as before. ## Checklist - [x] Tests added or updated - [x] Backward compatibility considered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes rg seed recursive searches with ignore rules from parent directories.
Why
Real rg honors parent
.ignore,.rgignore, and applicable.gitignorefiles when searching a child root, unless--no-ignore-parentis set. Bashkit only loaded ignore files inside the searched root.How
--no-ignoreand--no-ignore-parentbehavior.--no-ignore-parent.Risk
Checklist