Skip to content

refactor(builtins): BuiltinHelper trait, centralized limits, split ls/awk #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaliy merged 3 commits into from
May 26, 2026
Merged

refactor(builtins): BuiltinHelper trait, centralized limits, split ls/awk #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93d1e94
refactor(builtins): add BuiltinHelper trait, migrate 12 builtins
chaliy May 25, 2026
6f471e0
refactor(builtins): centralize per-builtin DoS limits in limits.rs
chaliy May 25, 2026
ad6f3e8
refactor(builtins): split ls.rs and awk.rs into directories
chaliy May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions crates/bashkit/src/builtins/archive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,11 @@ use flate2::write::GzEncoder;
use std::io::{Read, Write};
use std::path::Path;

use super::limits::ARCHIVE_MAX_DECOMPRESSION_RATIO as MAX_DECOMPRESSION_RATIO;
use super::{Builtin, Context, resolve_path};
use crate::error::Result;
use crate::interpreter::ExecResult;

/// Maximum decompression ratio to detect zip bombs.
/// A ratio over 100:1 is suspicious.
const MAX_DECOMPRESSION_RATIO: usize = 100;

/// Read from a decoder with size limits to prevent zip bombs.
///
/// Returns an error if the decompressed size exceeds the limit or
Expand Down
Loading
Loading