[chaliy]

Motivation

• A recent change split [[ ]] conditionals on || before && but did not track parenthesis depth, allowing inner || inside parentheses to be treated as a top-level operator and producing incorrect evaluations.

Description

• Add depth-aware helpers and only split on ||/&& when the operator is at the current parenthesis depth, implemented as find_top_level_conditional_*_operator for both raw Word and expanded-String paths in crates/bashkit/src/interpreter/mod.rs.
• Tighten parenthesis stripping so outer parentheses are removed only when they wrap the entire expression, via conditional_words_wrapped and conditional_args_wrapped for Word and String code paths respectively.
• Preserve lazy short-circuit evaluation behavior while using the depth-aware operator lookup so semantics and short-circuiting remain unchanged.
• Add two bash spec tests covering ( "$a" || "$b" ) && "$c" for both false and true scenarios in crates/bashkit/tests/spec_cases/bash/conditional.test.sh.

Testing

• Ran the bash spec suite subset: cargo test -p bashkit --test integration bash_spec_tests -- --nocapture, which passed (spec harness reported all bash spec tests passed).
• Ran formatting and lint checks: cargo fmt --check and cargo clippy -p bashkit --test integration -- -D warnings, both succeeded.

---

Codex Task

[Copilot]

Pull request overview

This PR fixes [[ ... ]] conditional parsing/evaluation in bashkit so &&/|| splitting respects parentheses depth, preventing inner operators inside (...) from being treated as top-level and preserving correct precedence and short-circuit behavior.

Changes:

• Add depth-aware helpers to find top-level || / && operators for both raw-Word and expanded-String evaluation paths.
• Tighten outer-parentheses stripping so parentheses are removed only when they wrap the entire conditional expression.
• Add bash spec tests covering ( "$a" || "$b" ) && "$c" for true/false scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/bashkit/src/interpreter/mod.rs	Makes conditional operator splitting and parentheses stripping depth-aware to preserve correct precedence/short-circuiting.
crates/bashkit/tests/spec_cases/bash/conditional.test.sh	Adds regression tests ensuring parenthesized `

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	bashkit	3aebade	Commit Preview URL	Jun 05 2026, 08:17 PM