Repository navigation
fix(tests): target consolidated integration harness - #1954
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates CI/workflows and developer scripts to target the consolidated Rust integration test harness (--test integration) using module filters, replacing now-removed standalone integration test binaries (e.g., spec_tests, proptest_differential, coreutils_differential_tests).
Changes:
- Updated workflow and local tooling to invoke
cargo test --test integration -- <module>::...for the same test subsets as before. - Refreshed the spec test module usage comment to document the new invocation pattern.
- Adjusted scripts/recipes that previously referenced the old standalone test targets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/update-spec-expected.sh |
Switches wrapper to run spec_tests::bash_comparison_tests via the consolidated integration binary. |
justfile |
Updates recipes to run spec/proptest integration modules through --test integration. |
crates/bashkit/tests/integration/spec_tests.rs |
Updates module doc comment to reference the consolidated integration harness invocation. |
.github/workflows/coreutils-args-drift.yml |
Updates workflow steps to run spec/coreutils drift-related tests via --test integration with module filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+67
| cargo test --test integration -- spec_tests::bash_comparison_tests --ignored --nocapture 2>&1 | ||
| else | ||
| cargo test --test spec_tests -- bash_comparison_tests --ignored 2>&1 | ||
| cargo test --test integration -- spec_tests::bash_comparison_tests --ignored 2>&1 |
Comment on lines
56
to
+58
| # Generate comprehensive compatibility report | ||
| compat-report: | ||
| cargo test --test spec_tests -- compatibility_report --ignored --nocapture | ||
| cargo test --test integration -- spec_tests::bash_comparison_tests --ignored --nocapture |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 4001e2a | Commit Preview URL | Jun 05 2026, 08:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
integrationtest binary, which removed standalone Cargo test targets likespec_tests,proptest_differential, andcoreutils_differential_tests, breaking CI and developer recipes that still invoked those targets.integrationtarget with module filters so tooling and CI continue to run the same test modules without reintroducing separate binaries.Description
--test spec_tests→--test integration -- spec_tests::...and--test proptest_differential→--test integration -- proptest_differential::..github/workflows/coreutils-args-drift.ymlto runspec_tests::bash_spec_testsandcoreutils_differential_tests::via theintegrationbinary.justfilerecipes to runspec_tests::bash_comparison_testsandproptest_differential::throughintegration.scripts/update-spec-expected.shwrapper and doc comment to targetintegrationwithspec_tests::bash_comparison_testsand refresh thespec_testsmodule usage comment incrates/bashkit/tests/integration/spec_tests.rs.Testing
cargo test -p bashkit --features http_client,ssh,sqlite --test integration --no-runwhich completed successfully.cargo test -p bashkit --test integration -- --list | rg '^(spec_tests::(bash_spec_tests|bash_comparison_tests)|proptest_differential::|coreutils_differential_tests::)'and verified expected modules are present..github/workflows,justfile, andscriptsand confirmed replacements removed the old targets.cargo fmt --checkwhich passed.Codex Task