Repository navigation
chore(deps): drop unused dependencies and apply major upgrades - #17
Merged
Merged
Conversation
Remove dependencies nothing uses: async-trait, futures, regex, unicode-segmentation, encoding_rs, base64, mime, lol_html and tracing-subscriber from core and the workspace, plus unused deps of the CLI, bindings and the stub bench/eval crates. The stub bench deps were the only source of the instant/paste unmaintained advisories, so their deny.toml ignores go too. Upgrade scraper 0.29, html5ever 0.40, pyo3 0.30, criterion 0.8 and quick-xml 0.42, which unifies with calamine's copy; port the XML walkers to its str-based names and values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
This is the dependency part of the maintenance pass. No extraction behavior changes.
async-trait,futures,regex,unicode-segmentation,encoding_rs,base64,mime,lol_html(it was on thehtmlfeature but nothing called it), andtracing-subscriber. Also unused deps of the CLI (serde), the Python binding (serde_json,tokio), the Node binding (tokio,serde,serde_json) and the stub bench/eval crates (instant,statrs,colored,tabled,reqwest, …).anyhowmoves to dev-deps in core because only a doc example uses it.&strnames and attribute values.instant/pasteunmaintained advisories, so bothdeny.tomlignores are removed. So are four license allowances that nothing uses any more. NOTICE no longer listslol_htmlorpdf-extract, which is not a dependency.loggingfeature is kept so existing feature lists still build. It now enables onlytracing, and the README calls it reserved because it emits nothing yet.Why
Bashkit's maintenance checklist: latest majors, no unused deps, review duplicates.
Before / After
Cargo.lockcargo auditcargo denyduplicate warningssyn1/2)deny.tomladvisory ignoresjust pre-prpasses locally (fmt, clippy-D warnings, all workspace tests including the document security suite, OKF check, script tests, examples, deny). XML entity tests (docx_billion_laughs_not_expanded,docx_external_entity_not_resolved) and ODS/XLS pre-scan tests pass on quick-xml 0.42.Risk
Checklist
loggingfeature kept)Generated by Claude Code