Repository navigation
feat(features)!: make http_client opt-in - #29
Merged
Merged
Conversation
Default markkit build no longer links reqwest/hyper. CLI and Python/Node bindings already enable http_client explicitly. CI asserts the default dependency tree stays network-free.
…-jep8ae # Conflicts: # crates/markkit/src/lib.rs # knowledge/log.md
…-jep8ae # Conflicts: # crates/markkit/Cargo.toml # knowledge/log.md
…-jep8ae # Conflicts: # knowledge/log.md
…-jep8ae # Conflicts: # knowledge/log.md
…-jep8ae # Conflicts: # knowledge/log.md
…-jep8ae # Conflicts: # knowledge/log.md
…-jep8ae # Conflicts: # CHANGELOG.md
…-jep8ae # Conflicts: # crates/markkit/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
http_clientis no longer a default feature ofmarkkit. Default build =htmlonly, with no HTTP/TLS stack. Library users who callextract_urladdfeatures = ["http_client"]. The CLI and Python/Node bindings already enable it explicitly, so theirextract_urlis unchanged. CI now also asserts the defaultmarkkitdependency tree has no reqwest/hyper.Docs updated: README feature table, crate docs, SECURITY.md, threat model T3 likelihood, maintenance checklist, AGENTS.md, CHANGELOG (breaking), knowledge log.
Why
URL fetching is the SSRF surface (T3); embedders should opt in to it rather than get a network stack by default.
Before / After
Before:
cargo tree -p markkit -e normal | grep -E 'reqwest|hyper'→ reqwest, hyper, ...After: no match (exit 1).
cargo test -p markkit(default),--features http_client,--all-features,cargo test --workspace, clippy-D warnings(default/no-default/all-features),check_okf.pyall pass.Risk
extract_urlmust enablehttp_client(compile error, not silent change).MarkkitTool(toolfeature) already gatesurlinput oncfg!(feature = "http_client").Checklist
🤖 Generated with Claude Code