Repository navigation
fix(spreadsheet): single-row sheets, workbook titles, XLSB detection - #33
Merged
Merged
Conversation
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # crates/markkit/src/extract.rs # crates/markkit/src/lib.rs # knowledge/log.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
First slice of the #11 follow-ups (format detection, correctness, panic profile):
| A | B |), and count instats.rows. Before, the row became a header with no data rows.Extraction.titleis filled for XLSX (docProps/core.xml), ODS (meta.xml) and XLS (SummaryInformation, code-page aware). Best effort: a malformed property part givesNone, never an error.application/vnd.ms-excel.sheet.binary.macroEnabled.12,.xlsbandxl/workbook.bincontainers map to the newFormat::Xlsbinstead ofXlsx. XLSB is still rejected withUnsupportedFormathere; the reader comes in a follow-up PR._rels/.rels: XLSX packages without it get the standard officeDocument relationship before calamine opens them, so they parse.panic = "unwind"in the release profile, so thecatch_unwindguard actually works in the CLI and the Python/Node bindings. Before, a parser panic aborted the process.\n).Why
These gaps showed up while making markkit fetchkit's Office backend (#11).
Before / After
single.xlsx(openpyxl, one row, title "FY26 Summary"):Before (
main):title:
nullAfter:
title:
"FY26 Summary"just fmt lint test check-okf test-scripts examplespass locally.cargo denyis not installed locally and runs in CI.Risk
Formatgains a variant (#[non_exhaustive], so not breaking). Slightly larger release binaries with unwind tables.Checklist
_rels, XLSB content type; new fuzz fixtures)Part of #11
Generated by Claude Code