Repository navigation
feat(spreadsheet): read XLSB workbooks with a bounds-checked BIFF12 reader - #39
Merged
Merged
Conversation
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # crates/markkit/src/extract.rs # crates/markkit/src/lib.rs # knowledge/log.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
XLSB (Excel binary workbook) is now converted to markdown in the
spreadsheetfeature instead of returningUnsupportedFormat.spreadsheet/xlsb.rs: a small BIFF12 record reader. Every varint, length and offset is bounds-checked, so a malformed record becomes an error instead of a panic. We don't use calamine's XLSB reader because it panics on malformed records.truncated_sheetwarnings, the cell pre-scan budget applies, the title comes fromdocProps/core.xml, andtrack_sourcesranges are recorded.tests/fixtures/xlsb/{date,issues}.xlsbare taken from calamine (MIT, see their README) and complemented by builders for synthetic workbooks.Why
Second part of the #11 follow-ups. fetchkit's Office backend needs
.xlsb.Before / After
markkit extract --file tests/fixtures/xlsb/date.xlsbBefore:
Unsupported format: XLSB (binary Excel workbook) is not supportedAfter:
just fmt lint test check-okf test-scripts examplespass locally.Risk
Checklist
Part of #11
Generated by Claude Code