Repository navigation
chore(deps): make tokio optional - #53
Merged
Merged
Conversation
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
- Single-row sheets render the row as data under Excel column letters - Extraction.title from XLSX core.xml, ODS meta.xml, XLS SummaryInformation - XLSB content type / extension / container detected as Format::Xlsb, not Xlsx - XLSX without _rels/.rels gets the standard package relationship - Release profile uses panic = "unwind" so catch_unwind guards work - Document the trailing newline as intended Part of #11
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # knowledge/log.md
…-foq2nw # Conflicts: # crates/markkit/src/extract.rs # crates/markkit/src/lib.rs # knowledge/log.md
New pptx feature (in all_formats): slides in sldIdLst order as '## Slide N: <title>' sections, bulleted body placeholders, text boxes, tables with spans, hyperlinks, speaker notes. Hidden slides skipped unless include_hidden_content. Shared OOXML helpers move from docx.rs to ooxml.rs. Legacy .ppt becomes Format::Ppt and is rejected explicitly. Part of #11
Extraction/ParsedDocument warnings become Vec<Warning> { code: WarningCode,
detail } so embedders match on a stable code instead of parsing strings.
Display keeps the old "code: detail" form; the agent tool output is
unchanged. Markkit derives Clone and Debug.
Part of #11
…-foq2nw # Conflicts: # CHANGELOG.md # crates/markkit/src/xml.rs
…-foq2nw # Conflicts: # crates/markkit-js/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11 (last remaining item: optional dependencies).
What changed
tokiois now an optional dependency ofmarkkit, pulled in only byhttp_client(tokio/net) andtool(tokio/sync). Default,docx,spreadsheet,pdf,pptx,markdownbuilds no longer link it.docx,spreadsheetdependency trees.serde_jsonstays required: always-on Jupyter notebook input (feat(formats): add Jupyter notebook input #50) parses JSON, so gating it would buy nothing. Documented in architecture.Why
Issue #11: embedders using only sync extraction paid for tokio.
Before / After
Before:
cargo tree -p markkit -e normal | grep -c tokio→ non-zero.After:
0for default and--no-default-features --features docx,spreadsheet. Every feature combo ("", none, docx+spreadsheet, pdf, pptx, markdown, tool, http_client, all) builds;just fmt lint test check-okf test-scripts examplesgreen; wasm32 build OK.Risk
Checklist
Generated by Claude Code