fix(e2e): call the synthetic endpoint with the shape it expects - #64
Merged
Merged
Conversation
The synthetic endpoint URL already includes the stage and route, and the request identifier is passed as syntheticUuid. Appending /production/outbound returned 403 and passing uuid returned 502, neither of which carries a request body, so the outbound relay assertions failed on a nil lookup.
|
Mattt (aevv)
marked this pull request as ready for review
August 25, 2026 20:19
Matt (matt-evervault)
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outbound relay e2e tests have been failing on a nil lookup (
undefined method '[]' for nilatoutbound_relay_e2e_spec.rb:18).The request was built two ways the endpoint does not accept:
{url}/production/outbound?uuid=…(before)Missing Authentication Token{url}?uuid=…Internal server error{url}?syntheticUuid=…(after){"request":{…}}The URL secret already includes
/production/outbound, and the identifier issyntheticUuid— which is what the node and python SDKs send. Neither failing response contains arequestkey, hence the nil.The assertions themselves were correct and are unchanged.