Repository navigation
Conversation
Both plugins imported opensnitch.dialogs.stats, removed in b87b67d. PluginsManager.load_plugin() does not catch import errors, so with either plugin enabled the UI failed to start. Import StatsDialog from opensnitch.dialogs.events, as virustotal does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both plugins still import
opensnitch.dialogs.stats, which was removed in b87b67d.PluginsManager.load_plugin()doesn't catch import errors, so with either plugin enabled the UI fails to start withModuleNotFoundError: No module named 'opensnitch.dialogs.stats'.This imports
StatsDialogfromopensnitch.dialogs.events, the same way the virustotal plugin does. Both plugins only use it fortype(parent) == StatsDialogchecks.It doesn't affect v1.8.0, only master since b87b67d. Without this, the next release 1.9.0 fails to start for users with either plugin enabled.
Found with an import smoke test of every UI module. I can send that test as a follow-up once #1678 is in, since it depends on the test isolation there.