Skip to content

ci: share the default node_modules cache with the v3 Node 24 test leg - #1203

Merged
HugoRCD merged 1 commit into
v3from
ci/v3-node24-cache
Nov 21, 2026
Merged

HugoRCD merged 1 commit into
v3from
ci/v3-node24-cache

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Nov 21, 2026

Copy link
Copy Markdown
Member

Written by an AI agent on behalf of @HugoRCD. @HugoRCD has not reviewed it yet.

Since #1201, the first push to v3 saved three node_modules cache entries instead of two. The Test matrix passes node-version: 24 to the setup action, which puts 24 in the cache key, while every other job reads .node-version and keys on that file's hash. Both run the same Node, so the 24 leg's entry is a second copy of the default one, about 500 MB of a cache quota the repository is already over. The 24 leg now passes an empty node-version, reads .node-version itself, and restores the default entry. The matrix value stays 24, so the job keeps its name Test (24) and the matrix.node-version == '24' condition later in the file is unaffected.

To check it once this lands, the next push to v3 should save no new node-modules-Linux-X64-24-… entry:

gh api "repos/evloghq/evlog/actions/caches?key=node-modules&ref=refs/heads/v3" --jq '.actions_caches[]|"\(.size_in_bytes/1e6|floor)MB \(.key[0:40])"'

Before

The three entries the first push to v3 saved (hashes shortened):

494MB refs/heads/v3 node-modules-Linux-X64-22-462a55b6…-
493MB refs/heads/v3 node-modules-Linux-X64-24-462a55b6…-
493MB refs/heads/v3 node-modules-Linux-X64-83df0ce3bd0df1f951f41b4f328bd73263563b1beab03b163e7dbca7843c4690-462a55b6…-

The Node version does not change: in the latest v3 push run (44910017910), Test (24) and Lint & typecheck both logged node: v24.22.3, the version in .node-version. If .node-version moves to another major, the leg named Test (24) follows the pin rather than staying on 24; the matrix comment already calls 24 "the .node-version pin". The duplicate entry already saved stays until GitHub expires it after 7 days without use.

ELI5

Two test jobs used the same version of Node but labelled their saved dependencies differently, so the project stored the same 500 MB twice. Now they share one copy.

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

5 Skipped Deployments
Project Deployment Actions Updated
evi Ignored Ignored Preview Nov 21, 2026 1:44pm UTC
evlog-docs Ignored Ignored v0 Nov 21, 2026 1:44pm UTC
evlog-render-lab Ignored Ignored Nov 21, 2026 1:44pm UTC
evlog-telemetry Ignored Ignored Nov 21, 2026 1:44pm UTC
just-use-evlog Ignored Ignored Nov 21, 2026 1:44pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ac0a823-db4a-4bcf-acaf-5f852c869f22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

Copy link
Copy Markdown
Contributor

Risk score: Typical (2/4)

Assessed at 5013d6a from the changed files and the title, by scripts/risk-score. A new push replaces this score.

  • On merge: changes CI workflows
  • CI and release: Release: changes CI steps: workflows/ci.yml
  • 1 files changed (5 lines), 0 of them tests
Area Level Why
CI and release Typical Release: changes CI steps: workflows/ci.yml

@pkg-pr-new

pkg-pr-new Bot commented Nov 21, 2026

Copy link
Copy Markdown
@evlog/cli

npm i https://pkg.pr.new/@evlog/cli@1203

@evlog/eve

npm i https://pkg.pr.new/@evlog/eve@1203

evlog

npm i https://pkg.pr.new/evlog@1203

@evlog/nuxthub

npm i https://pkg.pr.new/@evlog/nuxthub@1203

@evlog/signals

npm i https://pkg.pr.new/@evlog/signals@1203

@evlog/telemetry

npm i https://pkg.pr.new/@evlog/telemetry@1203

commit: 5013d6a

@HugoRCD
HugoRCD added this pull request to the merge queue Nov 21, 2026
Merged via the queue into v3 with commit 8964f32 Nov 21, 2026
28 of 29 checks passed
@HugoRCD
HugoRCD deleted the ci/v3-node24-cache branch November 21, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant