Repository navigation
ci: share the default node_modules cache with the v3 Node 24 test leg - #1203
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Thank you for following the naming conventions! 🙏 |
Risk score: Typical (2/4)Assessed at 5013d6a from the changed files and the title, by
|
@evlog/cli
@evlog/eve
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
Since #1201, the first push to
v3saved threenode_modulescache entries instead of two. The Test matrix passesnode-version: 24to the setup action, which puts24in the cache key, while every other job reads.node-versionand keys on that file's hash. Both run the same Node, so the 24 leg's entry is a second copy of the default one, about 500 MB of a cache quota the repository is already over. The 24 leg now passes an emptynode-version, reads.node-versionitself, and restores the default entry. The matrix value stays24, so the job keeps its nameTest (24)and thematrix.node-version == '24'condition later in the file is unaffected.To check it once this lands, the next push to
v3should save no newnode-modules-Linux-X64-24-…entry:Before
The three entries the first push to
v3saved (hashes shortened):The Node version does not change: in the latest
v3push run (44910017910),Test (24)andLint & typecheckboth loggednode: v24.22.3, the version in.node-version. If.node-versionmoves to another major, the leg namedTest (24)follows the pin rather than staying on 24; the matrix comment already calls 24 "the .node-version pin". The duplicate entry already saved stays until GitHub expires it after 7 days without use.ELI5
Two test jobs used the same version of Node but labelled their saved dependencies differently, so the project stored the same 500 MB twice. Now they share one copy.