Repository navigation
chore: merge main into v3 - #1204
Conversation
…che in the queue (#1200)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Thank you for following the naming conventions! 🙏 |
Risk score: High (3/4)Assessed at 984876a from the changed files and the title, by
|
@evlog/cli
@evlog/eve
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
Brings the 6 commits on
mainthatv3doesn't have intov3: the serverless request-end flushes (#1184), bounded request-end flushes with the Vercel and SvelteKitwaitUntilpickup (#1186), and four CI commits (#1192, #1193, #1199, #1200). It stays a draft until 2.37.0 (#1157) is on npm. Thenmaingets merged in once more, so the version PR's changelogs land here and the 16 changesets 2.37.0 consumed drop out ofv3. Like #1185, it lands by fast-forwardingv3to this branch's head, not by a squash, somainstays an ancestor ofv3.To check that after the fast-forward:
How the conflicts were resolved
.github/workflows/ci.ymland.github/actions/setup/action.yml:v3keeps its own files, identical tov3at 8964f32. Main split the tests intoTest evlogandTest @evlog/clijobs and saves thenode_modulescache and test durations frommainonly.v3already has its own layout (the Node 22/24 test matrix, eve compatibility, CLI smoke on Node 22.0.0 and Windows) and its own cache and merge-queue changes (ci: run the full suite in the v3 merge queue #1198, ci: cache node_modules and skip the store cache in the v3 merge queue #1201, ci: share the default node_modules cache with the v3 Node 24 test leg #1203), so main's job split isn't carried over.scripts/cli-sandbox.mjs: both sides kept. Main's runner, which runs each app in its own process, now also appliesv3's per-appapp.skip?.(name)check insidesmokeApp.Everything else merged cleanly, including #1184 and #1186's changes to
pipeline.ts,shutdown.ts, the shared middleware and the Nitro, Next and SvelteKit integrations.Bundle-size budget
#1184 and #1186 add 366 to 394 gzip bytes to each scenario, which puts all four over the budget that only
v3enforces. This raises them, as #1163 did, and every scenario is still under evlog@2.35.1.pnpm --filter evlog run size:budgetonv3at 8964f32:At this branch's head, with the raised budgets:
No published package source changes other than #1184 and #1186's, so the only changesets are their three (
drain-platform-waituntil,drain-request-budget,drain-request-end-flush). They go away with the second merge ofmainafter 2.37.0, together with the 13 that #1157 also consumes.Locally, I ran the evlog suite (2670 passed), the CLI suite (1089 passed), lint, typecheck for evlog, @evlog/cli and @evlog/eve, and
node scripts/cli-sandbox.mjs --smoke, which passed all 152 checks (19 checks × 8 apps). On this orb the smoke only runs withcommit.gpgsign=false, because the sandbox apps commit with the machine's git config; that's an orb setting, not the merge. Nobody has run the serverless flush on a real Vercel, Workers or Lambda deployment from this branch.Before this leaves draft, after #1157 merges:
git merge origin/mainagain. Keepv3's versions in everypackage.json, and put the 2.37.0,@evlog/cli0.13.0 and@evlog/signals0.3.0 changelog sections below the betas.ls .changeset.ELI5
The 2.x branch got a fix that makes logs reliably leave serverless functions before they freeze. This copies it into the 3.0 branch. The extra code makes the bundle a little bigger, so the size limits go up a little, and they're still smaller than an older release.