13/15 ddraw: colorkey, palettes, pixel formats - #14
Merged
Conversation
evmar
requested changes
Aug 20, 2026
| #[win32_derive::dllexport] | ||
| pub fn SetColorKey(_ctx: &mut Context, _this: u32) -> DD { | ||
| todo!() | ||
| pub fn SetColorKey(ctx: &mut Context, this: u32, dwFlags: u32, lpDDColorKey: u32) -> DD { |
Owner
There was a problem hiding this comment.
The pattern I was trying to use is that modules like ddraw1 or ddraw7 handle the specific function decoding of that API, and then shared functionality goes into methods in ddraw.rs. So I think this code belongs in ddraw.rs, and then ddraw7.rs won't need to call into ddraw1.rs.
avanturist888
force-pushed
the
slice/13
branch
from
August 20, 2026 17:32
bfc0e84 to
98d3934
Compare
Contributor
Author
|
Restructured the way you describe. |
avanturist888
force-pushed
the
slice/13
branch
from
August 20, 2026 18:08
98d3934 to
d34536a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 13 of 15, splitting up #1. Needs 9 merged first; on its own it does not compile.