Skip to content

🐛 app: fix clipped text on web - #1356

Merged
cruzdanilo merged 1 commit into
mainfrom
fixes
Sep 30, 2026
Merged

cruzdanilo merged 1 commit into
mainfrom
fixes

Conversation

@dieguezguille

@dieguezguille dieguezguille commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Fixed clipped text on web by adjusting line spacing.

@changeset-bot

changeset-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e607ffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/mobile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Walkthrough

StyledText now uses a normal line height on web. A Changeset declares a patch release for @exactly/mobile.

Changes

Web text rendering

Layer / File(s) Summary
Apply web line height
src/components/shared/Text.tsx, .changeset/quiet-herons-rise.md
StyledText sets lineHeight to "normal" on web. The Changeset declares a patch release for @exactly/mobile with the description “fix clipped text on web.”

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: 🔵 Low · up to e607f

Web text using typography variants such as the confirmation screen’s title3 may remain clipped. Apply the override to those variants before relying on this patch to fix that case.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing clipped text on web.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 498cdf84-46a9-478c-9014-bd08dcd22efd

📥 Commits

Reviewing files that changed from the base of the PR and between 18b57e2 and e607ffc.

📒 Files selected for processing (2)
  • .changeset/quiet-herons-rise.md
  • src/components/shared/Text.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread src/components/shared/Text.tsx
@cruzdanilo
cruzdanilo merged commit e607ffc into main Sep 30, 2026
9 of 12 checks passed
@cruzdanilo
cruzdanilo deleted the fixes branch September 30, 2026 16:52
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.96%. Comparing base (18b57e2) to head (e607ffc).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   71.88%   71.96%   +0.07%     
==========================================
  Files         304      304              
  Lines       12860    12861       +1     
  Branches     4763     4764       +1     
==========================================
+ Hits         9245     9255      +10     
+ Misses       3374     3365       -9     
  Partials      241      241              
Flag Coverage Δ
e2e 71.76% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
test — e607ffc9 Deployed Sep 30, 2026 by dieguezguille via e2e #14443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants