Support configurable database node counts#170
Draft
tkilias wants to merge 3 commits into
Draft
Conversation
tkilias
force-pushed
the
pr2/parallel-slow-tests
branch
from
43a8c18 to
3ac383f
Compare
tkilias
force-pushed
the
pr3/support-num-nodes
branch
from
7482e92 to
95fafc4
Compare
|
tkilias
changed the title
ahsimb
reviewed
Jun 29, 2026
| ), | ||
| ) | ||
| LOG.info("Creating database %s", name) | ||
| database_spec = openapi.models.CreateDatabase( |
Contributor
There was a problem hiding this comment.
Why not pass num_nodes in the constructor here?
ahsimb
reviewed
Jun 29, 2026
| def get_database_settings( | ||
| self, | ||
| database_id: str, | ||
| ) -> openapi.models.DatabaseSettings | None: |
Contributor
There was a problem hiding this comment.
Wrong type hint. The function either returns DatabaseSettings or raises an error, never returns None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR adds configurable database node counts on top of PR 2.
It includes:
num_nodessupport in the handwritten database creation helpersnum_nodesforwardingtest_database_num_nodes.pyWhy it changed
The feature needed to stay separate from the lifecycle fixes and the later refactor so reviewers can evaluate the behavior change and its test coverage in isolation.
Impact
Callers using the handwritten access helpers can now request explicit database node counts, and the node-count integration scenario is separated from the general lifecycle coverage.
Validation
poetry run pytest -q test/unit/test_api_access.pypoetry run nox -s format:checkpoetry run nox -s lint:typingIntegration tests requiring SaaS credentials were not run locally in this publish step.