chore: cover the editor bridge and SW client, tighten tooling, sync docs - #129
Merged
Merged
Conversation
- Add Vitest suites for EditorFrame (request-id routing, error replies, timeouts, foreign-origin messages), service-worker-client (activation, shared registration, session messages) and elpx-loader (filename and etag parsing), and count those modules toward the 90% threshold. - Require a numeric id on the asset route instead of casting '12abc' to 12. - Point biome.json at the installed Biome 2.5.14 schema. - AGENTS.md, DEVELOPMENT.md and comments: correct the SW path, skill name, save flow, sandbox flags, and stop referring to @nextcloud/viewer, webpack and the removed /editor page.
Contributor
Preview this PR in the Nextcloud PlaygroundA fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/remove-dead-code #129 +/- ##
============================================================
Coverage ? 93.81%
Complexity ? 149
============================================================
Files ? 25
Lines ? 776
Branches ? 89
============================================================
Hits ? 728
Misses ? 35
Partials ? 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5/5, based on #127.
What
Tests: new Vitest suites for:
EditorFrame: request-id routing, error replies, timeouts, ignoring foreign message sourcesservice-worker-client: activation, shared registration, session messages, posting failureselpx-loader: filename and ETag parsing, fallbacksThese modules now count toward the 90% coverage threshold, and the
codecov.ymlignores for them are removed. Coverage is 98.6% lines and 93.5% branches.Routes: the asset route requires a numeric
sessionId, so12abcno longer casts to 12.Biome:
biome.jsonnow points at the installed 2.5.14 schema.Docs:
@nextcloud/viewer./editorare fixed.Not in scope
Choosing between Biome and ESLint, since both lint
src/today.Verification