Keep make up working with a dirty editor clone or no network - #140
Merged
Merged
Conversation
Contributor
Test in WordPress PlaygroundTest the plugin with the code from this branch:
|
erseco
force-pushed
the
feature/make-up-offline
branch
from
September 26, 2026 07:20
636c169 to
c143d09
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/ci-harden-workflows #140 +/- ##
==============================================================
Coverage ? 96.87%
Complexity ? 864
==============================================================
Files ? 39
Lines ? 4324
Branches ? 0
==============================================================
Hits ? 4189
Misses ? 135
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
erseco
added this pull request to stack #144
September 26, 2026 07:38
erseco
force-pushed
the
feature/make-up-offline
branch
from
September 26, 2026 07:43
c143d09 to
3b456e2
Compare
erseco
force-pushed
the
feature/make-up-offline
branch
from
September 26, 2026 08:01
3b456e2 to
7623552
Compare
build-editor runs bun install, which rewrites the editor clone's bun.lock.
The next fetch-editor-source then refused to check out the new ref ("local
changes would be overwritten"), so make up failed on every run after the
first build once upstream moved. Discard that lockfile change before checkout.
build-editor-if-needed also aborted make up whenever the fetch failed, for
example offline, even with a usable build in dist/static. It now warns and
keeps the existing build in that case.
erseco
force-pushed
the
feature/make-up-offline
branch
from
September 26, 2026 08:29
7623552 to
0fd11b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #139.
make upfailing after the first editor buildbuild-editorrunsbun install, which rewrites the editor clone'sbun.lock. Once upstream moved, the nextmake up(throughbuild-editor-if-needed→fetch-editor-source) aborted:fetch-editor-sourcenow discards that lockfile change before checkout.--frozen-lockfileis not an option, because the upstream lock is not in sync with itspackage.json, so a frozen install fails.build-editor-if-neededalso abortedmake upwhenever the fetch failed, for example when offline, even thoughdist/static/held a usable build. It now warns and keeps the existing build.Verification
Tested against a throwaway clone:
bun.lock+ fetch ofmain: the clone moved to the new commit and was left clean;