Keep React's act() environment on in the block editor tests - #154
Merged
Merged
Conversation
Testing Library only sets IS_REACT_ACT_ENVIRONMENT when it finds global beforeAll/afterAll hooks. Since the suite imports them from vitest, the flag was left off and React state updates were no longer flushed inside act(), so some rendering paths silently stopped running.
Contributor
Test in WordPress PlaygroundTest the plugin with the code from this branch:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=========================================
Coverage 96.43% 96.43%
Complexity 806 806
=========================================
Files 36 36
Lines 4238 4238
=========================================
Hits 4087 4087
Misses 151 151
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #153.
@testing-library/reactonly turns on React'sact()environment (IS_REACT_ACT_ENVIRONMENT) when it finds globalbeforeAll/afterAllhooks. Withglobals: falsethe suite imports them fromvitest, so the flag was no longer set intests/js/elp_upload.test.js, and React state updates were not flushed insideact().On
mainthis changed no result or coverage number, but on thefeature/secure-iframe-sandboxbranch (#56), whose tests open the export menu, it silently droppedassets/js/elp-upload.jsfrom 66.16% to 58.64% lines: the menu body never rendered, yet the tests still passed. Setting the flag in the test file restores the previous behaviour; with it the branch is back to 66.16%.Testing
npm run test:js: 258/258, 95.84% lines, same as before.