Skip to content

Nucleotide Count: Fix syntax error #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larshp merged 2 commits into from
Aug 9, 2026
Merged

Nucleotide Count: Fix syntax error #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d67204
Nucleotide Count: Fix syntax error
mbtools Aug 7, 2026
51ec603
Update expected value type in nucleotide count tests
mbtools Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/practice/nucleotide-count/.meta/zcl_nucleotide_count.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ CLASS zcl_nucleotide_count DEFINITION
nucleotide TYPE c LENGTH 1,
count TYPE i,
END OF count_by_nucleotide,
nucleotide_counts TYPE STANDARD TABLE OF count_by_nucleotide WITH KEY nucleotide.
ty_nucleotide_counts TYPE STANDARD TABLE OF count_by_nucleotide WITH KEY nucleotide.
METHODS nucleotide_counts
IMPORTING
strand TYPE string
RETURNING
VALUE(result) TYPE nucleotide_counts
VALUE(result) TYPE ty_nucleotide_counts
RAISING
cx_parameter_invalid.
PROTECTED SECTION.
Expand Down
4 changes: 2 additions & 2 deletions exercises/practice/nucleotide-count/zcl_nucleotide_count.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ CLASS zcl_nucleotide_count DEFINITION
nucleotide TYPE c LENGTH 1,
count TYPE i,
END OF count_by_nucleotide,
nucleotide_counts TYPE STANDARD TABLE OF count_by_nucleotide WITH KEY nucleotide.
ty_nucleotide_counts TYPE STANDARD TABLE OF count_by_nucleotide WITH KEY nucleotide.
METHODS nucleotide_counts
IMPORTING
strand TYPE string
RETURNING
VALUE(result) TYPE nucleotide_counts
VALUE(result) TYPE ty_nucleotide_counts
RAISING
cx_parameter_invalid.
PROTECTED SECTION.
Expand Down
8 changes: 4 additions & 4 deletions exercises/practice/nucleotide-count/zcl_nucleotide_count.clas.testclasses.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ CLASS ltcl_nucleotide_count IMPLEMENTATION.
METHOD test_empty_strand.
cl_abap_unit_assert=>assert_equals(
act = cut->nucleotide_counts( '' )
exp = VALUE zcl_nucleotide_count=>nucleotide_counts(
exp = VALUE zcl_nucleotide_count=>ty_nucleotide_counts(
( nucleotide = 'A' count = 0 )
( nucleotide = 'C' count = 0 )
( nucleotide = 'G' count = 0 )
Expand All @@ -33,7 +33,7 @@ CLASS ltcl_nucleotide_count IMPLEMENTATION.
METHOD test_single_character.
cl_abap_unit_assert=>assert_equals(
act = cut->nucleotide_counts( 'G' )
exp = VALUE zcl_nucleotide_count=>nucleotide_counts(
exp = VALUE zcl_nucleotide_count=>ty_nucleotide_counts(
( nucleotide = 'A' count = 0 )
( nucleotide = 'C' count = 0 )
( nucleotide = 'G' count = 1 )
Expand All @@ -43,7 +43,7 @@ CLASS ltcl_nucleotide_count IMPLEMENTATION.
METHOD test_repeated_nucleotide.
cl_abap_unit_assert=>assert_equals(
act = cut->nucleotide_counts( 'GGGGGGG' )
exp = VALUE zcl_nucleotide_count=>nucleotide_counts(
exp = VALUE zcl_nucleotide_count=>ty_nucleotide_counts(
( nucleotide = 'A' count = 0 )
( nucleotide = 'C' count = 0 )
( nucleotide = 'G' count = 7 )
Expand All @@ -53,7 +53,7 @@ CLASS ltcl_nucleotide_count IMPLEMENTATION.
METHOD test_multiple_nucleotides.
cl_abap_unit_assert=>assert_equals(
act = cut->nucleotide_counts( 'AGCTTTTCATTCTGACTGCAACGGGCAATATGTCTCTGTGTGGATTAAAAAAAGAGTGTCTGATAGCAGC' )
exp = VALUE zcl_nucleotide_count=>nucleotide_counts(
exp = VALUE zcl_nucleotide_count=>ty_nucleotide_counts(
( nucleotide = 'A' count = 20 )
( nucleotide = 'C' count = 12 )
( nucleotide = 'G' count = 17 )
Expand Down