phone-number: return null on invalid input

[keiravillekode]

Remove interface version check in bin/.test-in-docker

[kotp]

Approving, but this would have been a good opportunity for @norwd to discuss this in the forums, as indicated in the README, and get their first contribution, and for the work that started on #567 to be continued.

I wonder if we should let them work on this, or if it is urgent enough for us to take over?

[keiravillekode]

There was an unrelated problem that bin/.test-in-docker was checking for version 2. Fixing that is the "urgent" part: it blocks any PRs on this track.

[kotp]

There was an unrelated problem that bin/.test-in-docker was checking for version 2. Fixing that is the "urgent" part: it blocks any PRs on this track.

Unrelated then should at a minimum be a different commit, but I would argue having unrelated things in a pull request would either make the pull request be titled with an "and" which often indicates it should be two pull requests, or perhaps the unrelated should be its own thing.

This way if one is reverted, the other remains.

Let's fix the urgent part that is blocking you be its own thing, and I can help you get that over the line immediately, while allowing a potentially new contributor have their moment.

[norwd]

this would have been a good opportunity for @norwd to discuss this in the forums

My bad, I was frustrated yesterday as the instructions didn't cover any of the negative test cases, I ended up having to reverse engineer the expected format. In my haste I opened a PR without seeing the disclaimer in the README 🤦

We 💙 our community but this repository does not accept unsolicited pull requests at this time.

I'll head over to the forum to see if anybody else had trouble with that exercise.