Skip to content

Quarantine inconsistent discovery snapshots without blocking analytics - #33

Merged
marcociav-exmergo merged 1 commit into
mainfrom
fix/quarantine-discovery-snapshots
Nov 8, 2026
Merged

marcociav-exmergo merged 1 commit into
mainfrom
fix/quarantine-discovery-snapshots

Conversation

@marcociav-exmergo

@marcociav-exmergo marcociav-exmergo commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

What changes

A GitHub referrer snapshot reported more unique visitors than total views, causing this scheduled run to fail during sync-candidate. Because imports validate historical snapshots, a future corrected capture could not unblock publication.

Quarantine the entire affected referrer/path snapshot while retaining its original CSV, checksum, revision, and capture timestamp. Keep the capture as a null selection barrier so MetricFlow cannot resurrect older counts. Status and publication metadata identify the quarantine and offending rows. Exact-date/comparison recipes and affected trend windows report unavailable. Valid endpoints and repositories continue through normal validation; malformed inputs and daily traffic violations still fail.

Validation

  • Ingestion regression tests: 36 passed.
  • Complete local integration suite: 88 passed, 1 skipped (the opt-in external smoke test), in 10m14s. Hosted CI also passed on Python 3.11 and 3.12 (17m00s / 17m54s).
  • Replayed the exact failing raw candidate e32f6b797c62ac4634a4574adae6510bdb1958cb: import, verified build (verification.ran: true), committed-definition check, previous-baseline adoption, Maintain check/verify, and freshness all passed. Status is ready/fresh and the quarantined-date recipe explicitly returns unavailable.
  • All four Maintain axes ran. No blocking findings: one medium path-cardinality increase and low-severity empty optional-source findings. The report retains the prior-baseline age warning and existing unresolved-join/set-operation verification warnings; these are not presented as verified joins. No baseline was refreshed.
  • Real MetricFlow regressions cover both endpoints, latest capture selection, period aggregation, comparisons, empty reports, isolation, publication evidence, and recovery.
  • Ruff lint and formatting passed.

Analytics engineering checklist

  • No SQL, YAML, model, or metric-definition changes; no Transform plan or baseline replacement is needed.
  • Explored the existing snapshot/discovery schemas with the pinned Dex engine.
  • Integration regressions build with Dex verification and check against the previous baseline, including all four Maintain axes.
  • Updated the metric contract, question documentation, operations guide, and agent instructions.

Baseline change

  • No baseline change.

Release target: v1.1.2 after passing CI and merge.

@marcociav-exmergo
marcociav-exmergo marked this pull request as ready for review November 8, 2026 15:00
@marcociav-exmergo
marcociav-exmergo merged commit 2ae23d2 into main Nov 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant