Repository navigation
fix: Name CONDITIONS_NOT_EVALUATED on endpoint tool pages (#635) - #687
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While bean condition evaluation is disabled in the settings, an endpoint record has no
beanCondition, and a caller cannot tell "the bean is active" from "conditions were not evaluated". The bean tools already say so withlimitations: ["CONDITIONS_NOT_EVALUATED"]; the endpoint tools did not.Change
explyt_find_spring_endpoint,explyt_get_spring_http_endpointsandexplyt_get_spring_endpoint_contractput an envelope-levellimitations: ["CONDITIONS_NOT_EVALUATED"]on every page (first page, thenearestByPrefixsample on the first page, continuation pages) while evaluation is disabled. The key is absent while conditions are evaluated, so the output with evaluation on is unchanged.maxCharsand theRESPONSE_TOO_LARGEhint includes it. The setting was already part of the revision (feat: Bound and continue the endpoint MCP tool responses (#635) #675), so all pages of one revision agree.INVALID_ARGUMENT,RESULT_CHANGED,RESPONSE_TOO_LARGE) carry nolimitations, as in the bean tools: they carry no endpoints.Verification
limitations; 3 controls (evaluation on) passed.SpringBootApplicationMcpToolsetActuatorBeanConditionTest20/20,SpringBootApplicationMcpToolsetDescriptorTest9/9;:spring-ai:test785 tests, 0 failures, 0 errors (59 fresh JUnit XML files).spring-ai only (252+).
Closes #635