Skip to content

fix: Name CONDITIONS_NOT_EVALUATED on endpoint tool pages (#635) - #687

Merged
imuromtsev merged 2 commits into
mainfrom
imuromtsev/endpoint-conditions-not-evaluated
Oct 14, 2026
Merged

imuromtsev merged 2 commits into
mainfrom
imuromtsev/endpoint-conditions-not-evaluated

Conversation

@imuromtsev

Copy link
Copy Markdown
Collaborator

Purpose

While bean condition evaluation is disabled in the settings, an endpoint record has no beanCondition, and a caller cannot tell "the bean is active" from "conditions were not evaluated". The bean tools already say so with limitations: ["CONDITIONS_NOT_EVALUATED"]; the endpoint tools did not.

Change

  • explyt_find_spring_endpoint, explyt_get_spring_http_endpoints and explyt_get_spring_endpoint_contract put an envelope-level limitations: ["CONDITIONS_NOT_EVALUATED"] on every page (first page, the nearestByPrefix sample on the first page, continuation pages) while evaluation is disabled. The key is absent while conditions are evaluated, so the output with evaluation on is unchanged.
  • The limitation is part of the measured envelope, so pages stay within maxChars and the RESPONSE_TOO_LARGE hint includes it. The setting was already part of the revision (feat: Bound and continue the endpoint MCP tool responses (#635) #675), so all pages of one revision agree.
  • Error envelopes (INVALID_ARGUMENT, RESULT_CHANGED, RESPONSE_TOO_LARGE) carry no limitations, as in the bean tools: they carry no endpoints.
  • The shared condition sentence of the three tool descriptions names the limitation.

Verification

  • Red commit 69770ff: 6 tests (first and continuation page of each tool with evaluation off) failed on the missing limitations; 3 controls (evaluation on) passed.
  • After the fix: SpringBootApplicationMcpToolsetActuatorBeanConditionTest 20/20, SpringBootApplicationMcpToolsetDescriptorTest 9/9; :spring-ai:test 785 tests, 0 failures, 0 errors (59 fresh JUnit XML files).

spring-ai only (252+).

Closes #635

@imuromtsev imuromtsev added the spring-mcp-tools Explyt MCP tools (explyt_*); need JetBrains MCP Server, IDEA 2025.2+ label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
TestsPassed ✅Skipped ⚠️Failed
JUnit Test Report4407 ran4401 passed6 skipped0 failed

@imuromtsev
imuromtsev merged commit 6c55260 into main Oct 14, 2026
2 checks passed
@imuromtsev
imuromtsev deleted the imuromtsev/endpoint-conditions-not-evaluated branch October 14, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spring-mcp-tools Explyt MCP tools (explyt_*); need JetBrains MCP Server, IDEA 2025.2+

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endpoint MCP tools have no character budget

1 participant