Skip to content

[eas-cli] Supabase integration base - #4130

Open
gwdp wants to merge 9 commits into
mainfrom
gwdp/eng-25327-m3a-supabase-foundation
Open

[eas-cli] Supabase integration base #4130
gwdp wants to merge 9 commits into
mainfrom
gwdp/eng-25327-m3a-supabase-foundation

Conversation

@gwdp

@gwdp gwdp commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Why

Adding the shared layer for the Supabase integration commands (connect / disconnect / dashboard): GraphQL, provisioning, and writing credentials into EAS env.

While extracting it, environment defaults/resolution moved out of integrations/. They aren't integration-specific, and eas env already uses the same list.

How

  • Supabase GraphQL client pieces (mutations/queries/types)
  • Helpers under integrations/supabase/ (and a thin shared/ for SDK install + .env.local)
  • Top-level environments/ so default env resolution isn't buried in integrations
  • Hardened background-job receipt polling for async provision

Test Plan

CI

@linear-code

linear-code Bot commented Aug 1, 2026

Copy link
Copy Markdown

ENG-25327

@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch from 701da7b to 4ec60eb Compare August 1, 2026 00:52
@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch from 4ec60eb to ac84241 Compare August 1, 2026 02:13
@gwdp gwdp changed the title [eas-cli] Supabase integration: foundation (GraphQL, shared helpers, provisioning) [eas-cli] Supabase integration foundation Aug 1, 2026
@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch from ac84241 to 1ff6a8c Compare August 1, 2026 02:28
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.81481% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.94%. Comparing base (42cf2cb) to head (b1a0203).

Files with missing lines Patch % Lines
...ackages/eas-cli/src/integrations/shared/envFile.ts 98.39% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
+ Coverage   62.49%   62.94%   +0.45%     
==========================================
  Files        1008     1019      +11     
  Lines       45810    46340     +530     
  Branches     9251     9770     +519     
==========================================
+ Hits        28625    29164     +539     
+ Misses      17058    15719    -1339     
- Partials      127     1457    +1330     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch from adb8ca9 to ae2a0de Compare August 3, 2026 02:08
@gwdp gwdp changed the title [eas-cli] Supabase integration foundation [eas-cli] Supabase integration base Aug 3, 2026
@gwdp
gwdp requested a review from FiberJW August 3, 2026 02:29
@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch 3 times, most recently from c865fe4 to 842d59a Compare August 4, 2026 14:52
@gwdp
gwdp marked this pull request as ready for review August 4, 2026 15:04
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@FiberJW FiberJW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some small changes to improve polling:

Comment thread packages/eas-cli/src/environments/resolve.ts
Comment thread packages/eas-cli/src/integrations/supabase/env.ts Outdated
Comment thread packages/eas-cli/src/integrations/supabase/provision.ts
Comment thread packages/eas-cli/src/integrations/supabase/provision.ts
Comment thread packages/eas-cli/src/integrations/supabase/provision.ts
Comment thread packages/eas-cli/src/integrations/supabase/provision.ts Outdated
@gwdp
gwdp requested a review from FiberJW August 6, 2026 04:09
@gwdp

gwdp commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Requesting some small changes to improve polling:

Thank you for the review, got some changes in and replied to the rest; let me know if you disagree on any, happy to discuss more :)

gwdp added 9 commits August 6, 2026 17:34
Stop suggesting --environment with --link; that combo is rejected by connect.
Call shared writeEnvLocal / env upsert / resolveTargetEnvironments
with the Supabase label at the callsite instead of one-arg wrappers.
Call shared setupSdkAndConfigAsync with packages/plugin/label at
the connect callsite instead of thin binder wrappers.
Drop constant-only sdk.ts/environments.ts into env.ts. Move the
generic writeEnvVarsAsync loop into environments/variables.
@gwdp
gwdp force-pushed the gwdp/eng-25327-m3a-supabase-foundation branch from b58c227 to b1a0203 Compare August 7, 2026 00:34
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants