[eas-cli] Add --max-idle-time-minutes flag to eas simulator - #4156
[eas-cli] Add --max-idle-time-minutes flag to eas simulator#4156szdziedzic wants to merge 1 commit into
Conversation
5d7a255 to
95419a1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
=======================================
Coverage 62.43% 62.43%
=======================================
Files 1008 1008
Lines 45730 45730
Branches 9625 9625
=======================================
Hits 28548 28548
Misses 15721 15721
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
95419a1 to
e933995
Compare
🤖 AI code reviewDecision: Approve Overall PR risk: Low. The change is additive: it adds one optional No findings. This review is advisory — it never blocks a merge and never auto-approves. |
9ced7ee to
e933995
Compare
|
✅ Thank you for adding the changelog entry! |
Why
EAS Simulator sessions cost money while they run. Today a session that nobody uses keeps running until its max duration. This PR adds the CLI half of an opt-in idle timeout: the user sets it when starting the session, and EAS stops the session after that many minutes without activity.
Related PRs:
maxIdleTimeMinutesand passes themax_idle_time_minutesstep input)How
eas simulatorgets a new optional--max-idle-time-minutesinteger flag. It is passed asmaxIdleTimeMinutesonCreateDeviceRunSessionInput. The CLI only rejects negative values; the server owns the allowed range and rejects the value for serve-sim sessions, which have no activity signal yet.generated.tsis hand-edited to include the new input field until the server schema ships.Deployment order
max_idle_time_minutesstep input, so jobs never crash on it. The timeout only takes effect once workers run that code.maxIdleTimeMinutes, adds the mutation input field, and starts sending the step input.maxIdleTimeMinutesinput field until then, and theverify-graphql-codecheck here fails until the schema ships.Test Plan
createDeviceRunSessionmutation.eas-clisimulator suites pass.yarn typecheck,yarn lint, andyarn fmt:checkare clean across all packages.🤖 Generated with Claude Code