[build-tools] Add direct DADB mode for Maestro tests - #4163
Draft
sjchmiela wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4163 +/- ##
==========================================
+ Coverage 62.50% 62.50% +0.01%
==========================================
Files 1008 1008
Lines 45815 45827 +12
Branches 9256 9652 +396
==========================================
+ Hits 28630 28641 +11
+ Misses 17058 15725 -1333
- Partials 127 1461 +1334 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
android_connection_modeinput toeas/maestro_tests.adbas the default and supportdadbfor direct Android device connections.Why
Maestro uses DADB, but DADB first uses or starts the local ADB server. Some Android Maestro runs fail when the ADB server loses the emulator connection and leaves the device offline. This mode lets selected jobs bypass the ADB server and connect directly to
adbd. Existing jobs keep the current behavior.Implementation
In
dadbmode, the step:adbshim first in Maestro'sPATH.finally.Cleanup failures do not replace the Maestro result.
Validation
yarn workspace @expo/build-tools typecheckyarn workspace @expo/build-tools jest-unit --runInBand(104 suites, 987 tests)yarn fmt:checkyarn lint(0 errors; 14 unrelated existing warnings)