test(req): cover req.is() when given an array of types - #7394
Closed
Errr0rr404 wants to merge 1 commit into
Closed
Conversation
The array branch in lib/request.js was the only uncovered branch in that file. Adds tests matching the documented String|Array API. Fixes expressjs#7348
Author
|
Note for reviewers: #7112 also touches |
Contributor
|
Duplicate of #6703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
req.is()documentsString|Arraytypes, but the array branch had no test coverage.Fixes #7348
Test plan
test/req.is.js